Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

docs: add test for using FOR UPDATE #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions 47 test/mockserver_tests/mock_server_test_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

from google.cloud.spanner_dbapi.parsed_statement import AutocommitDmlMode
from sqlalchemy import Engine, create_engine
from sqlalchemy.testing.plugin.plugin_base import fixtures
Expand Down Expand Up @@ -79,6 +80,52 @@ def add_single_result(
MockServerTestBase.spanner_service.mock_spanner.add_result(sql, result)


def add_singer_query_result(sql: str):
result = result_set.ResultSet(
dict(
metadata=result_set.ResultSetMetadata(
dict(
row_type=spanner_type.StructType(
dict(
fields=[
spanner_type.StructType.Field(
dict(
name="singers_id",
type=spanner_type.Type(
dict(code=spanner_type.TypeCode.INT64)
),
)
),
spanner_type.StructType.Field(
dict(
name="singers_name",
type=spanner_type.Type(
dict(code=spanner_type.TypeCode.STRING)
),
)
),
]
)
)
)
),
)
)
result.rows.extend(
[
(
"1",
"Jane Doe",
),
(
"2",
"John Doe",
),
]
)
add_result(sql, result)


class MockServerTestBase(fixtures.TestBase):
server: grpc.Server = None
spanner_service: SpannerServicer = None
Expand Down
35 changes: 35 additions & 0 deletions 35 test/mockserver_tests/test_basics.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@
String,
func,
text,
BigInteger,
)
from sqlalchemy.orm import Session, DeclarativeBase, Mapped, mapped_column
from sqlalchemy.testing import eq_, is_instance_of
from google.cloud.spanner_v1 import (
FixedSizePool,
Expand All @@ -41,6 +43,7 @@
add_result,
add_single_result,
add_update_count,
add_singer_query_result,
)


Expand Down Expand Up @@ -179,3 +182,35 @@ def test_partitioned_dml(self):
)
results = connection.execute(text(sql)).rowcount
eq_(100, results)

def test_select_for_update(self):
class Base(DeclarativeBase):
pass

class Singer(Base):
__tablename__ = "singers"
id: Mapped[int] = mapped_column(BigInteger, primary_key=True)
name: Mapped[str] = mapped_column(String)

query = (
"SELECT singers.id AS singers_id, singers.name AS singers_name\n"
"FROM singers\n"
"WHERE singers.id = @a0\n"
" LIMIT @a1 FOR UPDATE"
)
add_singer_query_result(query)
update = "UPDATE singers SET name=@a0 WHERE singers.id = @a1"
add_update_count(update, 1)

engine = create_engine(
"spanner:///projects/p/instances/i/databases/d",
connect_args={"client": self.client, "pool": FixedSizePool(size=10)},
)

with Session(engine) as session:
singer = (
session.query(Singer).filter(Singer.id == 1).with_for_update().first()
)
singer.name = "New Name"
session.add(singer)
session.commit()
54 changes: 4 additions & 50 deletions 54 test/mockserver_tests/test_read_only_transaction.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@
BeginTransactionRequest,
TransactionOptions,
)
from test.mockserver_tests.mock_server_test_base import MockServerTestBase
from test.mockserver_tests.mock_server_test_base import add_result
import google.cloud.spanner_v1.types.type as spanner_type
import google.cloud.spanner_v1.types.result_set as result_set
from test.mockserver_tests.mock_server_test_base import (
MockServerTestBase,
add_singer_query_result,
)


class TestReadOnlyTransaction(MockServerTestBase):
Expand Down Expand Up @@ -71,49 +71,3 @@ def test_read_only_transaction(self):
),
begin_request.options,
)


def add_singer_query_result(sql: str):
result = result_set.ResultSet(
dict(
metadata=result_set.ResultSetMetadata(
dict(
row_type=spanner_type.StructType(
dict(
fields=[
spanner_type.StructType.Field(
dict(
name="singers_id",
type=spanner_type.Type(
dict(code=spanner_type.TypeCode.INT64)
),
)
),
spanner_type.StructType.Field(
dict(
name="singers_name",
type=spanner_type.Type(
dict(code=spanner_type.TypeCode.STRING)
),
)
),
]
)
)
)
),
)
)
result.rows.extend(
[
(
"1",
"Jane Doe",
),
(
"2",
"John Doe",
),
]
)
add_result(sql, result)
58 changes: 6 additions & 52 deletions 58 test/mockserver_tests/test_stale_reads.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,17 @@
BeginTransactionRequest,
TransactionOptions,
)
from test.mockserver_tests.mock_server_test_base import MockServerTestBase
from test.mockserver_tests.mock_server_test_base import add_result
import google.cloud.spanner_v1.types.type as spanner_type
import google.cloud.spanner_v1.types.result_set as result_set
from test.mockserver_tests.mock_server_test_base import (
MockServerTestBase,
add_singer_query_result,
)


class TestStaleReads(MockServerTestBase):
def test_stale_read_multi_use(self):
from test.mockserver_tests.stale_read_model import Singer

add_singer_query_result("SELECT singers.id, singers.name \n" + "FROM singers")
add_singer_query_result("SELECT singers.id, singers.name \nFROM singers")
engine = create_engine(
"spanner:///projects/p/instances/i/databases/d",
echo=True,
Expand Down Expand Up @@ -82,7 +82,7 @@ def test_stale_read_multi_use(self):
def test_stale_read_single_use(self):
from test.mockserver_tests.stale_read_model import Singer

add_singer_query_result("SELECT singers.id, singers.name\n" + "FROM singers")
add_singer_query_result("SELECT singers.id, singers.name \nFROM singers")
engine = create_engine(
"spanner:///projects/p/instances/i/databases/d",
echo=True,
Expand Down Expand Up @@ -121,49 +121,3 @@ def test_stale_read_single_use(self):
),
execute_request.transaction.single_use,
)


def add_singer_query_result(sql: str):
result = result_set.ResultSet(
dict(
metadata=result_set.ResultSetMetadata(
dict(
row_type=spanner_type.StructType(
dict(
fields=[
spanner_type.StructType.Field(
dict(
name="singers_id",
type=spanner_type.Type(
dict(code=spanner_type.TypeCode.INT64)
),
)
),
spanner_type.StructType.Field(
dict(
name="singers_name",
type=spanner_type.Type(
dict(code=spanner_type.TypeCode.STRING)
),
)
),
]
)
)
)
),
)
)
result.rows.extend(
[
(
"1",
"Jane Doe",
),
(
"2",
"John Doe",
),
]
)
add_result(sql, result)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.