From 94d6ec7770e607203bb63b1f564571fffa192b9a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Knut=20Olav=20L=C3=B8ite?= Date: Tue, 24 Oct 2023 14:22:33 +0200 Subject: [PATCH 1/3] chore: fix build and lint errors --- google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py | 2 +- test/test_suite_20.py | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py b/google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py index 9fe09140..ca20e134 100644 --- a/google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py +++ b/google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py @@ -304,7 +304,7 @@ def render_literal_value(self, value, type_): generate a SQL statement. """ raw = ["\\", "'", '"', "\n", "\t", "\r"] - if type(value) == str and any(single in value for single in raw): + if isinstance(value, str) and any(single in value for single in raw): value = 'r"""{}"""'.format(value) return value else: diff --git a/test/test_suite_20.py b/test/test_suite_20.py index b4bf26fa..c16d4763 100644 --- a/test/test_suite_20.py +++ b/test/test_suite_20.py @@ -2495,6 +2495,11 @@ class IsOrIsNotDistinctFromTest(_IsOrIsNotDistinctFromTest): pass +@pytest.mark.skip("Spanner doesn't bizarre characters in foreign key names") +class BizarroCharacterFKResolutionTest(fixtures.TestBase): + pass + + class OrderByLabelTest(_OrderByLabelTest): @pytest.mark.skip( "Spanner requires an alias for the GROUP BY list when specifying derived " From 2526f3b23524eabd84665b10140d05497d360e13 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Knut=20Olav=20L=C3=B8ite?= Date: Tue, 24 Oct 2023 14:32:42 +0200 Subject: [PATCH 2/3] test: skip another test using auto increment --- test/test_suite_20.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/test_suite_20.py b/test/test_suite_20.py index c16d4763..7cef8c8d 100644 --- a/test/test_suite_20.py +++ b/test/test_suite_20.py @@ -2111,6 +2111,10 @@ def test_empty_insert_multiple(self): def test_insert_from_select_autoinc(self): pass + @pytest.mark.skip("Spanner does not support auto increment") + def test_no_results_for_non_returning_insert(self, connection, style, executemany): + pass + def test_autoclose_on_insert(self): """ SPANNER OVERRIDE: From bdc09f189a86f29c7ef0b120d09599ac472380a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Knut=20Olav=20L=C3=B8ite?= Date: Tue, 24 Oct 2023 14:40:47 +0200 Subject: [PATCH 3/3] test: skip isolation level test --- test/test_suite_20.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/test/test_suite_20.py b/test/test_suite_20.py index 7cef8c8d..ea537a3c 100644 --- a/test/test_suite_20.py +++ b/test/test_suite_20.py @@ -2504,6 +2504,12 @@ class BizarroCharacterFKResolutionTest(fixtures.TestBase): pass +class IsolationLevelTest(fixtures.TestBase): + @pytest.mark.skip("Cloud Spanner does not support different isolation levels") + def test_dialect_user_setting_is_restored(self, testing_engine): + pass + + class OrderByLabelTest(_OrderByLabelTest): @pytest.mark.skip( "Spanner requires an alias for the GROUP BY list when specifying derived "