Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

chore: fix build and lint errors #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 2 google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ def render_literal_value(self, value, type_):
generate a SQL statement.
"""
raw = ["\\", "'", '"', "\n", "\t", "\r"]
if type(value) == str and any(single in value for single in raw):
if isinstance(value, str) and any(single in value for single in raw):
value = 'r"""{}"""'.format(value)
return value
else:
Expand Down
15 changes: 15 additions & 0 deletions 15 test/test_suite_20.py
Original file line number Diff line number Diff line change
Expand Up @@ -2111,6 +2111,10 @@ def test_empty_insert_multiple(self):
def test_insert_from_select_autoinc(self):
pass

@pytest.mark.skip("Spanner does not support auto increment")
def test_no_results_for_non_returning_insert(self, connection, style, executemany):
pass

def test_autoclose_on_insert(self):
"""
SPANNER OVERRIDE:
Expand Down Expand Up @@ -2495,6 +2499,17 @@ class IsOrIsNotDistinctFromTest(_IsOrIsNotDistinctFromTest):
pass


@pytest.mark.skip("Spanner doesn't bizarre characters in foreign key names")
class BizarroCharacterFKResolutionTest(fixtures.TestBase):
pass


class IsolationLevelTest(fixtures.TestBase):
@pytest.mark.skip("Cloud Spanner does not support different isolation levels")
def test_dialect_user_setting_is_restored(self, testing_engine):
pass


class OrderByLabelTest(_OrderByLabelTest):
@pytest.mark.skip(
"Spanner requires an alias for the GROUP BY list when specifying derived "
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.