Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

RFC: disables sequence support #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2023
Merged

RFC: disables sequence support #326

merged 1 commit into from
May 31, 2023

Conversation

cofin
Copy link
Contributor

@cofin cofin commented May 29, 2023

Fixes #325

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label May 29, 2023
@asthamohta asthamohta added the automerge Merge the pull request once unit tests and other checks pass. label May 30, 2023
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 30, 2023
@asthamohta asthamohta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 31, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 31, 2023
@asthamohta asthamohta merged commit 7b441ff into googleapis:main May 31, 2023
@release-please release-please bot mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asthamohta asthamohta asthamohta approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dialect configured with sequences enabled.
3 participants
@cofin @asthamohta @yoshi-kokoro
Morty Proxy This is a proxified and sanitized view of the page, visit original site.