Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

docs: add docs build kokoro config for django spanner #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jun 17, 2021
Merged

docs: add docs build kokoro config for django spanner #644

merged 21 commits into from
Jun 17, 2021

Conversation

vi3k6i5
Copy link
Contributor

@vi3k6i5 vi3k6i5 commented Jun 15, 2021 •
edited
Loading

docs: added docs build kokoro config for django spanner.

fixes #643

Docs will be published at link: https://googleapis.dev/python/django-google-spanner/latest/index.html

@vi3k6i5 vi3k6i5 requested a review from a team as a code owner June 15, 2021 07:27
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Jun 15, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 15, 2021
busunkim96
busunkim96 reviewed Jun 15, 2021
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments on .repo-metadata.json, otherwise LGTM. :)

.repo-metadata.json Outdated Show resolved Hide resolved
.repo-metadata.json Outdated Show resolved Hide resolved
@vi3k6i5 vi3k6i5 changed the title docs: added docs build kokoro config for django spanner. docs: added docs build kokoro config for django spanner Jun 15, 2021
vi3k6i5 added 13 commits June 16, 2021 00:38
@vi3k6i5
fix:repo metadata
c1c2e6a
@vi3k6i5
fix: updated PROJECT_ROOT for django spanner docs build using kokoro
074e1f9
@vi3k6i5
fix: remove sudo apt update because sudo is not allowed
975298c
@vi3k6i5
fix: add build_nox.sh as original build.sh file is used by kokoro wor…
5d86b7f 
…kers to run parallelized tests
@vi3k6i5
refactor: renamed build_nox.sh to build-nox.sh
79a0d62
@vi3k6i5
refactor: change build-nox to nox.sh
d27017f
@vi3k6i5
refactor: change build-nox to nox.sh
851a4ac
@vi3k6i5
refactor: change kokoro build to run different test for docs and diff…
e37957c 
…erent test for workers
@vi3k6i5
refactor: change kokoro build to run different test for docs and diff…
ff4915b 
…erent test for workers
@vi3k6i5
refactor: add log msg for debugging
b0ec9b2
@vi3k6i5
refactor: remove log msg added for debugging
9457c20
@vi3k6i5
fix: correct docs build command
6666172
@vi3k6i5
refactor: remove unused nox file
2cdaae7
@vi3k6i5
Copy link
Contributor Author

vi3k6i5 commented Jun 16, 2021

Some small comments on .repo-metadata.json, otherwise LGTM. :)

@busunkim96 : Fixed the comments, Thanks for the help :)

@busunkim96
Copy link
Contributor

I think you'll need to copy https://github.com/googleapis/python-spanner/blob/master/.trampolinerc into this repo as well. I triggered the docs job manually and it appears to be failing on a missing bucket name: log

@vi3k6i5
Copy link
Contributor Author

vi3k6i5 commented Jun 16, 2021

I think you'll need to copy https://github.com/googleapis/python-spanner/blob/master/.trampolinerc into this repo as well. I triggered the docs job manually and it appears to be failing on a missing bucket name: log

Added the same file, thanks

busunkim96
busunkim96 approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the docs jobs is all good now! You should see them at googleapis.dev/python/django-spanner-google/latest in a bit. :) docs job log

@vi3k6i5 vi3k6i5 requested review from c24t and larkee June 16, 2021 20:11
@busunkim96
Copy link
Contributor

Docs are live! https://googleapis.dev/python/django-google-spanner/latest/index.html

FYI If you want to view the docs locally, you can run nox -s docs and open docs/_build/html in a browser.

larkee
larkee approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the docs at the given link so this LGTM 👍

@larkee larkee changed the title docs: added docs build kokoro config for django spanner docs: add docs build kokoro config for django spanner Jun 17, 2021
@vi3k6i5 vi3k6i5 merged commit ecf241a into googleapis:master Jun 17, 2021
This was referenced Apr 17, 2024
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@larkee larkee larkee approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

@asthamohta asthamohta Awaiting requested review from asthamohta

@c24t c24t Awaiting requested review from c24t

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation for django spanner.
3 participants
@vi3k6i5 @busunkim96 @larkee
Morty Proxy This is a proxified and sanitized view of the page, visit original site.