Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit d05fb2d

Browse filesBrowse files
c24tvi3k6i5
c24t
authored and
vi3k6i5
committed
fix: Update links in comments to use googleapis repo (#622)
1 parent 61e63f7 commit d05fb2d
Copy full SHA for d05fb2d

File tree

Expand file treeCollapse file tree

3 files changed

+21
-21
lines changed
Filter options
Expand file treeCollapse file tree

3 files changed

+21
-21
lines changed

‎django_spanner/__init__.py

Copy file name to clipboardExpand all lines: django_spanner/__init__.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def datetimewithnanoseconds_eq(self, other):
5757
return False
5858

5959
# Otherwise try to convert them to an equvialent form.
60-
# See https://github.com/orijtech/spanner-orm/issues/272
60+
# See https://github.com/googleapis/python-spanner-django/issues/272
6161
if isinstance(other, datetime.datetime):
6262
return self.ctime() == other.ctime()
6363

‎django_spanner/features.py

Copy file name to clipboardExpand all lines: django_spanner/features.py
+17-17Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -168,17 +168,17 @@ class DatabaseFeatures(BaseDatabaseFeatures):
168168
"syndication_tests.tests.SyndicationFeedTest.test_rss091_feed",
169169
"syndication_tests.tests.SyndicationFeedTest.test_template_feed",
170170
# datetimes retrieved from the database with the wrong hour when
171-
# USE_TZ = True: https://github.com/orijtech/spanner-orm/issues/193
171+
# USE_TZ = True: https://github.com/googleapis/python-spanner-django/issues/193
172172
"datetimes.tests.DateTimesTests.test_21432",
173173
"db_functions.datetime.test_extract_trunc.DateFunctionWithTimeZoneTests.test_trunc_func_with_timezone",
174174
"db_functions.datetime.test_extract_trunc.DateFunctionWithTimeZoneTests.test_trunc_timezone_applied_before_truncation", # noqa
175175
# extract() with timezone not working as expected:
176-
# https://github.com/orijtech/spanner-orm/issues/191
176+
# https://github.com/googleapis/python-spanner-django/issues/191
177177
"timezones.tests.NewDatabaseTests.test_query_datetimes",
178-
# using NULL with + crashes: https://github.com/orijtech/spanner-orm/issues/201
178+
# using NULL with + crashes: https://github.com/googleapis/python-spanner-django/issues/201
179179
"annotations.tests.NonAggregateAnnotationTestCase.test_combined_annotation_commutative",
180180
# Spanner loses DecimalField precision due to conversion to float:
181-
# https://github.com/orijtech/spanner-orm/pull/133#pullrequestreview-328482925
181+
# https://github.com/googleapis/python-spanner-django/pull/133#pullrequestreview-328482925
182182
"aggregation.tests.AggregateTestCase.test_decimal_max_digits_has_no_effect",
183183
"aggregation.tests.AggregateTestCase.test_related_aggregate",
184184
"db_functions.comparison.test_cast.CastTests.test_cast_to_decimal_field",
@@ -191,16 +191,16 @@ class DatabaseFeatures(BaseDatabaseFeatures):
191191
"aggregation.test_filter_argument.FilteredAggregateTests.test_filtered_numerical_aggregates",
192192
"aggregation_regress.tests.AggregationTests.test_stddev",
193193
# SELECT list expression references <column> which is neither grouped
194-
# nor aggregated: https://github.com/orijtech/spanner-orm/issues/245
194+
# nor aggregated: https://github.com/googleapis/python-spanner-django/issues/245
195195
"aggregation_regress.tests.AggregationTests.test_annotated_conditional_aggregate",
196196
"aggregation_regress.tests.AggregationTests.test_annotation_with_value",
197197
"expressions.tests.BasicExpressionsTests.test_filtering_on_annotate_that_uses_q",
198198
# "No matching signature for operator" crash when comparing TIMESTAMP
199-
# and DATE: https://github.com/orijtech/django-spanner/issues/255
199+
# and DATE: https://github.com/googleapis/python-spanner-django/issues/255
200200
"expressions.tests.BasicExpressionsTests.test_outerref_mixed_case_table_name",
201201
"expressions.tests.FTimeDeltaTests.test_mixed_comparisons1",
202202
# duration arithmetic fails with dates: No matching signature for
203-
# function TIMESTAMP_ADD: https://github.com/orijtech/django-spanner/issues/253
203+
# function TIMESTAMP_ADD: https://github.com/googleapis/python-spanner-django/issues/253
204204
"expressions.tests.FTimeDeltaTests.test_date_comparison",
205205
"expressions.tests.FTimeDeltaTests.test_date_minus_duration",
206206
"expressions.tests.FTimeDeltaTests.test_delta_add",
@@ -212,12 +212,12 @@ class DatabaseFeatures(BaseDatabaseFeatures):
212212
"select_for_update.tests.SelectForUpdateTests.test_unsupported_select_for_update_with_limit",
213213
# integer division produces a float result, which can't be assigned to
214214
# an integer column:
215-
# https://github.com/orijtech/django-spanner/issues/331
215+
# https://github.com/googleapis/python-spanner-django/issues/331
216216
"expressions.tests.ExpressionOperatorTests.test_lefthand_division",
217217
"expressions.tests.ExpressionOperatorTests.test_right_hand_division",
218218
# power operator produces a float result, which can't be assigned to
219219
# an integer column:
220-
# https://github.com/orijtech/django-spanner/issues/331
220+
# https://github.com/googleapis/python-spanner-django/issues/331
221221
"expressions.tests.ExpressionOperatorTests.test_lefthand_power",
222222
"expressions.tests.ExpressionOperatorTests.test_righthand_power",
223223
# Cloud Spanner's docs: "The rows that are returned by LIMIT and OFFSET
@@ -238,18 +238,18 @@ class DatabaseFeatures(BaseDatabaseFeatures):
238238
"db_functions.math.test_mod.ModTests.test_decimal",
239239
"db_functions.math.test_mod.ModTests.test_float",
240240
# casting DateField to DateTimeField adds an unexpected hour:
241-
# https://github.com/orijtech/spanner-orm/issues/260
241+
# https://github.com/googleapis/python-spanner-django/issues/260
242242
"db_functions.comparison.test_cast.CastTests.test_cast_from_db_date_to_datetime",
243243
# Tests that fail during tear down on databases that don't support
244-
# transactions: https://github.com/orijtech/spanner-orm/issues/271
244+
# transactions: https://github.com/googleapis/python-spanner-django/issues/271
245245
"admin_views.test_multidb.MultiDatabaseTests.test_add_view",
246246
"admin_views.test_multidb.MultiDatabaseTests.test_change_view",
247247
"admin_views.test_multidb.MultiDatabaseTests.test_delete_view",
248248
"auth_tests.test_admin_multidb.MultiDatabaseTests.test_add_view",
249249
"auth_tests.test_remote_user_deprecation.RemoteUserCustomTest.test_configure_user_deprecation_warning",
250250
"contenttypes_tests.test_models.ContentTypesMultidbTests.test_multidb",
251251
# Tests that by-pass using django_spanner and generate
252-
# invalid DDL: https://github.com/orijtech/django-spanner/issues/298
252+
# invalid DDL: https://github.com/googleapis/python-spanner-django/issues/298
253253
"cache.tests.CreateCacheTableForDBCacheTests",
254254
"cache.tests.DBCacheTests",
255255
"cache.tests.DBCacheWithTimeZoneTests",
@@ -280,15 +280,15 @@ class DatabaseFeatures(BaseDatabaseFeatures):
280280
# backend needs it (which it currently doesn't).
281281
"introspection.tests.IntrospectionTests.test_get_key_columns",
282282
# DatabaseIntrospection.get_relations() isn't implemented:
283-
# https://github.com/orijtech/django-spanner/issues/311
283+
# https://github.com/googleapis/python-spanner-django/issues/311
284284
"introspection.tests.IntrospectionTests.test_get_relations",
285285
# pyformat parameters not supported on INSERT:
286-
# https://github.com/orijtech/django-spanner/issues/343
286+
# https://github.com/googleapis/python-spanner-django/issues/343
287287
"backends.tests.BackendTestCase.test_cursor_execute_with_pyformat",
288288
"backends.tests.BackendTestCase.test_cursor_executemany_with_pyformat",
289289
"backends.tests.BackendTestCase.test_cursor_executemany_with_pyformat_iterator",
290290
# duplicate table raises GoogleAPICallError rather than DatabaseError:
291-
# https://github.com/orijtech/django-spanner/issues/344
291+
# https://github.com/googleapis/python-spanner-django/issues/344
292292
"backends.tests.BackendTestCase.test_duplicate_table_error",
293293
"migrations.test_commands.MigrateTests.test_migrate_fake_initial",
294294
"migrations.test_commands.MigrateTests.test_migrate_initial_false",
@@ -340,10 +340,10 @@ class DatabaseFeatures(BaseDatabaseFeatures):
340340
# support transactions.
341341
"migrations.test_executor.ExecutorTests.test_atomic_operation_in_non_atomic_migration",
342342
# changing a not null constraint isn't allowed if it affects an index:
343-
# https://github.com/orijtech/django-spanner/issues/378
343+
# https://github.com/googleapis/python-spanner-django/issues/378
344344
"migrations.test_operations.OperationTests.test_alter_field_with_index",
345345
# parsing INSERT with one inlined value and one placeholder fails:
346-
# https://github.com/orijtech/django-spanner/issues/393
346+
# https://github.com/googleapis/python-spanner-django/issues/393
347347
"migrations.test_operations.OperationTests.test_run_sql_params",
348348
# This test doesn't flush the database properly:
349349
# https://code.djangoproject.com/ticket/31398

‎django_spanner/introspection.py

Copy file name to clipboardExpand all lines: django_spanner/introspection.py
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,9 @@ def get_relations(self, cursor, table_name):
106106
representing all the relationships in the table.
107107
108108
TODO: DO NOT USE THIS METHOD UNTIL
109-
https://github.com/orijtech/django-spanner/issues/313
109+
https://github.com/googleapis/python-spanner-django/issues/313
110110
is resolved so that foreign keys can be supported, as documented in:
111-
https://github.com/orijtech/django-spanner/issues/311
111+
https://github.com/googleapis/python-spanner-django/issues/311
112112
113113
:type cursor: :class:`~google.cloud.spanner_dbapi.cursor.Cursor`
114114
:param cursor: A reference to a Spanner Database cursor.
@@ -228,7 +228,7 @@ def get_constraints(self, cursor, table_name):
228228
already_added = constraint in constraints
229229
if constraint_type == "FOREIGN KEY":
230230
# We don't yet support anything related to FOREIGN KEY.
231-
# See https://github.com/orijtech/django-spanner/issues/313.
231+
# See https://github.com/googleapis/python-spanner-django/issues/313.
232232
if already_added:
233233
del constraints[constraint]
234234
continue

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.