Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

tracing: update CloudSpanner.Transaction.execute_streaming_sql to execute_sql; start Transaction.commit span up top to ensure #1286

Copy link
Copy link
Closed
@odeke-em

Description

@odeke-em
Issue body actions

An issue for myself to fix requests from our last review session

  • update "CloudSpanner.Transaction.execute_streaming_sql" span name to "execute_sql"
  • Starting the CloudSpanner.Transaction.commit span before the inlined .begin()
  • Ensure that using a tracer_provider with ALWAYS_OFF set doesn't crash due to NonRecording span not having _span
-            if (not span._status) or span._status.status_code == StatusCode.UNSET:
+            if getattr(span, '_status', None) is None or span._status.status_code == StatusCode.UNSET:

Thanks @harshachinta @surbhigarg92 @sakthivelmanii

Metadata

Metadata

Assignees

Labels

api: spannerIssues related to the googleapis/python-spanner API.Issues related to the googleapis/python-spanner API.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.