Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

test: Added timestamp to sink names + autodelete sinks older than 2 hours in export_test.py #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 1, 2024

Conversation

gkevinzheng
Copy link
Contributor

@gkevinzheng gkevinzheng commented Aug 1, 2024

Added a timestamp field in TEST_SINK_NAME_IMPL and a cleanup threshold so that the export_test.py test suite deletes sinks older than 2 hours when run.

Also added exponential backoff to sink deletion to reduce the chances of sink deletion failure.

Fixes #923

@gkevinzheng gkevinzheng requested review from a team as code owners August 1, 2024 17:55
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 1, 2024
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Aug 1, 2024
@gkevinzheng gkevinzheng changed the title chore: Running this to remove all sinks fix: Added timestamp to sink names + autodelete sinks older than 2 hours in export_test.py Aug 1, 2024
samples/snippets/export_test.py Show resolved Hide resolved
@parthea parthea changed the title fix: Added timestamp to sink names + autodelete sinks older than 2 hours in export_test.py test: Added timestamp to sink names + autodelete sinks older than 2 hours in export_test.py Aug 1, 2024
@parthea parthea merged commit b86081e into main Aug 1, 2024
16 of 17 checks passed
@parthea parthea deleted the samples-cleanup branch August 1, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/python-logging API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up samples resources
3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.