Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

fix: Document -> types.Document #227

Merged
merged 2 commits into from
Dec 7, 2021
Merged

fix: Document -> types.Document #227

merged 2 commits into from
Dec 7, 2021

Conversation

andrewferlitsch
Copy link
Contributor

@andrewferlitsch andrewferlitsch commented Dec 6, 2021 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@andrewferlitsch andrewferlitsch requested a review from a team as a code owner December 6, 2021 21:08
@product-auto-label product-auto-label bot added the api: language Issues related to the googleapis/python-language API. label Dec 6, 2021
engelke
engelke approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke engelke merged commit 01367d7 into main Dec 7, 2021
@engelke engelke deleted the issue_202904985 branch December 7, 2021 22:08
@release-please release-please bot mentioned this pull request Jan 11, 2022
Closed
This was referenced Jan 19, 2022
Closed
Closed
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 20, 2022
@release-please
chore(main): release 2.3.2 (#252)
105be7b 
🤖 I have created a release *beep* *boop*
---


### [2.3.2](v2.3.1...v2.3.2) (2022-01-20)


### Documentation

* **samples:** Document -> types.Document ([#227](#227)) ([01367d7](01367d7))


---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-please release-please bot mentioned this pull request Nov 4, 2022
Merged
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Jul 6, 2023
@release-please
chore(main): release 2.3.2 (#252)
d0417ef 
🤖 I have created a release *beep* *boop*
---


### [2.3.2](googleapis/python-language@v2.3.1...v2.3.2) (2022-01-20)


### Documentation

* **samples:** Document -> types.Document ([#227](googleapis/python-language#227)) ([01367d7](googleapis/python-language@01367d7))


---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@engelke engelke engelke approved these changes

Assignees
No one assigned
Labels
api: language Issues related to the googleapis/python-language API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewferlitsch @engelke
Morty Proxy This is a proxified and sanitized view of the page, visit original site.