Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Dec 17, 2023. It is now read-only.

chore(sample): Monorepo Migration Completed and Deprecate #630

Merged
merged 3 commits into from
Mar 9, 2023

Conversation

yil532
Copy link
Contributor

@yil532 yil532 commented Mar 8, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
snippet-bot:force-run

@yil532 yil532 requested review from a team as code owners March 8, 2023 23:00
@yil532 yil532 requested a review from engelke March 8, 2023 23:00
@snippet-bot
Copy link

snippet-bot bot commented Mar 8, 2023

Here is the summary of possible violations 😱

There are 7 possible violations for removing region tag in use.

The end of the violation section. All the stuff below is FYI purposes only.


Here is the summary of changes.

You are about to delete 33 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Mar 8, 2023
@yil532 yil532 requested a review from telpirion March 8, 2023 23:00
@product-auto-label product-auto-label bot added the api: dialogflow Issues related to the googleapis/python-dialogflow API. label Mar 8, 2023
@yil532 yil532 requested a review from dandhlee March 8, 2023 23:04
@yil532 yil532 changed the title migrate and delete chore(sample): Monorepo Migration Completed and Deprecate Mar 8, 2023
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@yil532 yil532 added the snippet-bot:force-run Force snippet-bot runs its logic label Mar 8, 2023
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Mar 8, 2023
@dandhlee dandhlee added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2023
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@dandhlee
Copy link
Contributor

dandhlee commented Mar 9, 2023

Failures from Snippetbot should be fine to ignore - manually checked that all pages have been converted but it's just taking the bot some time to catch up. Good to merge!

@yil532 yil532 merged commit 1f50343 into main Mar 9, 2023
@yil532 yil532 deleted the monorepo-migration branch March 9, 2023 02:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: dialogflow Issues related to the googleapis/python-dialogflow API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.