Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jul 6, 2023. It is now read-only.

chore: Fix resource annotations for Cloud Deploy to use common resource name for locations #136

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Sep 27, 2022

  • Regenerate this pull request now.

This is technically a breaking change in that it's modifying the type for a resource, but it's a fast-follow fix to the earlier broken definition.

PiperOrigin-RevId: 477192133

Source-Link: googleapis/googleapis@f252e11

Source-Link: https://github.com/googleapis/googleapis-gen/commit/34ca7cd6da0ac5920011c8bda01e8bc32b7da444
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzRjYTdjZDZkYTBhYzU5MjAwMTFjOGJkYTAxZThiYzMyYjdkYTQ0NCJ9

…e name for locations

This is technically a breaking change in that it's modifying the type for a resource, but it's a fast-follow fix to the earlier broken definition.

PiperOrigin-RevId: 477192133

Source-Link: googleapis/googleapis@f252e11

Source-Link: https://github.com/googleapis/googleapis-gen/commit/34ca7cd6da0ac5920011c8bda01e8bc32b7da444
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzRjYTdjZDZkYTBhYzU5MjAwMTFjOGJkYTAxZThiYzMyYjdkYTQ0NCJ9
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners September 27, 2022 18:49
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 27, 2022
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: clouddeploy Issues related to the googleapis/python-deploy API. labels Sep 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Sep 27, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 27, 2022
@parthea parthea changed the title fix!: Fix resource annotations for Cloud Deploy to use common resource name for locations chore: Fix resource annotations for Cloud Deploy to use common resource name for locations Sep 29, 2022
@parthea
Copy link
Contributor

parthea commented Sep 29, 2022

Using conventional commit prefix to chore: as the methods removed were not yet released.

@parthea parthea merged commit 61898d3 into main Sep 29, 2022
@parthea parthea deleted the owl-bot-copy branch September 29, 2022 15:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: clouddeploy Issues related to the googleapis/python-deploy API. owl-bot-copy size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.