Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

chore: Python code samples migrated to python-doc-samples #348

Merged
merged 3 commits into from
Dec 7, 2022
Merged

chore: Python code samples migrated to python-doc-samples #348

merged 3 commits into from
Dec 7, 2022

Conversation

msampathkumar
Copy link
Contributor

For more details, please check GoogleCloudPlatform/python-docs-samples#8529

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@msampathkumar msampathkumar requested review from a team as code owners November 28, 2022 13:37
@snippet-bot
Copy link

snippet-bot bot commented Nov 28, 2022 •
edited
Loading

Here is the summary of changes.

You are about to delete 14 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: containeranalysis Issues related to the googleapis/python-containeranalysis API. samples Issues that are directly related to samples. labels Nov 28, 2022
@msampathkumar msampathkumar added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 28, 2022
@msampathkumar
Copy link
Contributor Author

Update: http://cl/491320894 is in WIP. Added do not merge tag for now.

If this CL is completed, then please clear it and merged this PR. Thanks.

@msampathkumar
Copy link
Contributor Author

Update: http://cl/491320894 is completed! Clearing do not merge tag.

@msampathkumar msampathkumar removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 29, 2022
@msampathkumar msampathkumar changed the title Python code samples migrated to python-doc-samples chore: Python code samples migrated to python-doc-samples Nov 29, 2022
@msampathkumar
Merge branch 'main' into b_257074849
f1b6092 
# Conflicts:
#	samples/snippets/noxfile.py
#	samples/snippets/requirements.txt
#	samples/snippets/samples.py
#	samples/snippets/samples_test.py
@msampathkumar msampathkumar merged commit ede0f1a into main Dec 7, 2022
@msampathkumar msampathkumar deleted the b_257074849 branch December 7, 2022 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees
No one assigned
Labels
api: containeranalysis Issues related to the googleapis/python-containeranalysis API. samples Issues that are directly related to samples. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msampathkumar @kurtisvg
Morty Proxy This is a proxified and sanitized view of the page, visit original site.