Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

fix: Updated max_results to 100 to avoid too many API calls #108

Merged
merged 1 commit into from
Aug 20, 2021
Merged

fix: Updated max_results to 100 to avoid too many API calls #108

merged 1 commit into from
Aug 20, 2021

Conversation

rsamborski
Copy link
Member

@rsamborski rsamborski commented Aug 19, 2021 •
edited
Loading

Based on @amanda-tarafa comment in C# sample (https://github.com/GoogleCloudPlatform/dotnet-docs-samples/pull/1445/files#r687921807) I am changing the max_results value to 100

Checklist:

  • [N/A] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • [N/A] Appropriate docs were updated (if necessary)

🦕

@rsamborski rsamborski added samples Issues that are directly related to samples. api: compute Issues related to the googleapis/python-compute API. labels Aug 19, 2021
@rsamborski rsamborski requested a review from a team as a code owner August 19, 2021 13:58
@rsamborski rsamborski requested a review from leahecole August 19, 2021 13:58
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 19, 2021
@leahecole leahecole changed the title Updated max_results to 100 to avoid too many API calls fix: Updated max_results to 100 to avoid too many API calls Aug 19, 2021
@leahecole
Copy link
Contributor

LGTM! @rsamborski please follow the steps in the "Details" section next to the failing check to amend the commit message and then we should be good to merge! 😄

@rsamborski rsamborski merged commit 691e38e into master Aug 20, 2021
@rsamborski rsamborski deleted the rsamborski-patch-1 branch August 20, 2021 13:54
@release-please release-please bot mentioned this pull request Jan 13, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leahecole leahecole leahecole approved these changes

@m-strzelczyk m-strzelczyk Awaiting requested review from m-strzelczyk

Assignees
No one assigned
Labels
api: compute Issues related to the googleapis/python-compute API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsamborski @leahecole
Morty Proxy This is a proxified and sanitized view of the page, visit original site.