diff --git a/.release-please-manifest.json b/.release-please-manifest.json index a2914e5..a3d1f01 100644 --- a/.release-please-manifest.json +++ b/.release-please-manifest.json @@ -1,3 +1,3 @@ { - ".": "3.17.0" + ".": "3.17.1" } diff --git a/CHANGELOG.md b/CHANGELOG.md index 0ef2d36..ecde7d4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,13 @@ [1]: https://pypi.org/project/google-cloud-build/#history +## [3.17.1](https://github.com/googleapis/python-cloudbuild/compare/v3.17.0...v3.17.1) (2023-07-04) + + +### Bug Fixes + +* Add async context manager return types ([#413](https://github.com/googleapis/python-cloudbuild/issues/413)) ([794de7a](https://github.com/googleapis/python-cloudbuild/commit/794de7afc5bd254c6dd6433c81cc59d00d62ad41)) + ## [3.17.0](https://github.com/googleapis/python-cloudbuild/compare/v3.16.0...v3.17.0) (2023-06-29) diff --git a/google/cloud/devtools/cloudbuild/gapic_version.py b/google/cloud/devtools/cloudbuild/gapic_version.py index 60a5f14..404743e 100644 --- a/google/cloud/devtools/cloudbuild/gapic_version.py +++ b/google/cloud/devtools/cloudbuild/gapic_version.py @@ -13,4 +13,4 @@ # See the License for the specific language governing permissions and # limitations under the License. # -__version__ = "3.17.0" # {x-release-please-version} +__version__ = "3.17.1" # {x-release-please-version} diff --git a/google/cloud/devtools/cloudbuild_v1/gapic_version.py b/google/cloud/devtools/cloudbuild_v1/gapic_version.py index 60a5f14..404743e 100644 --- a/google/cloud/devtools/cloudbuild_v1/gapic_version.py +++ b/google/cloud/devtools/cloudbuild_v1/gapic_version.py @@ -13,4 +13,4 @@ # See the License for the specific language governing permissions and # limitations under the License. # -__version__ = "3.17.0" # {x-release-please-version} +__version__ = "3.17.1" # {x-release-please-version} diff --git a/google/cloud/devtools/cloudbuild_v1/services/cloud_build/async_client.py b/google/cloud/devtools/cloudbuild_v1/services/cloud_build/async_client.py index 4803550..dcb5ae6 100644 --- a/google/cloud/devtools/cloudbuild_v1/services/cloud_build/async_client.py +++ b/google/cloud/devtools/cloudbuild_v1/services/cloud_build/async_client.py @@ -2682,7 +2682,7 @@ async def sample_list_worker_pools(): # Done; return the response. return response - async def __aenter__(self): + async def __aenter__(self) -> "CloudBuildAsyncClient": return self async def __aexit__(self, exc_type, exc, tb): diff --git a/google/cloud/devtools/cloudbuild_v2/gapic_version.py b/google/cloud/devtools/cloudbuild_v2/gapic_version.py index 60a5f14..404743e 100644 --- a/google/cloud/devtools/cloudbuild_v2/gapic_version.py +++ b/google/cloud/devtools/cloudbuild_v2/gapic_version.py @@ -13,4 +13,4 @@ # See the License for the specific language governing permissions and # limitations under the License. # -__version__ = "3.17.0" # {x-release-please-version} +__version__ = "3.17.1" # {x-release-please-version} diff --git a/google/cloud/devtools/cloudbuild_v2/services/repository_manager/async_client.py b/google/cloud/devtools/cloudbuild_v2/services/repository_manager/async_client.py index 514a2c6..20d1b91 100644 --- a/google/cloud/devtools/cloudbuild_v2/services/repository_manager/async_client.py +++ b/google/cloud/devtools/cloudbuild_v2/services/repository_manager/async_client.py @@ -2339,7 +2339,7 @@ async def test_iam_permissions( # Done; return the response. return response - async def __aenter__(self): + async def __aenter__(self) -> "RepositoryManagerAsyncClient": return self async def __aexit__(self, exc_type, exc, tb): diff --git a/google/cloud/devtools/cloudbuild_v2/services/repository_manager/transports/rest.py b/google/cloud/devtools/cloudbuild_v2/services/repository_manager/transports/rest.py index 3264722..52453df 100644 --- a/google/cloud/devtools/cloudbuild_v2/services/repository_manager/transports/rest.py +++ b/google/cloud/devtools/cloudbuild_v2/services/repository_manager/transports/rest.py @@ -2314,7 +2314,7 @@ def __call__( request_kwargs = json_format.MessageToDict(request) transcoded_request = path_template.transcode(http_options, **request_kwargs) - body = json.loads(json.dumps(transcoded_request["body"])) + body = json.dumps(transcoded_request["body"]) uri = transcoded_request["uri"] method = transcoded_request["method"] @@ -2386,7 +2386,7 @@ def __call__( request_kwargs = json_format.MessageToDict(request) transcoded_request = path_template.transcode(http_options, **request_kwargs) - body = json.loads(json.dumps(transcoded_request["body"])) + body = json.dumps(transcoded_request["body"]) uri = transcoded_request["uri"] method = transcoded_request["method"] @@ -2455,7 +2455,7 @@ def __call__( request_kwargs = json_format.MessageToDict(request) transcoded_request = path_template.transcode(http_options, **request_kwargs) - body = json.loads(json.dumps(transcoded_request["body"])) + body = json.dumps(transcoded_request["body"]) uri = transcoded_request["uri"] method = transcoded_request["method"] diff --git a/samples/generated_samples/snippet_metadata_google.devtools.cloudbuild.v1.json b/samples/generated_samples/snippet_metadata_google.devtools.cloudbuild.v1.json index 5bfff84..664cfd3 100644 --- a/samples/generated_samples/snippet_metadata_google.devtools.cloudbuild.v1.json +++ b/samples/generated_samples/snippet_metadata_google.devtools.cloudbuild.v1.json @@ -8,7 +8,7 @@ ], "language": "PYTHON", "name": "google-cloud-build", - "version": "3.17.0" + "version": "3.17.1" }, "snippets": [ { diff --git a/samples/generated_samples/snippet_metadata_google.devtools.cloudbuild.v2.json b/samples/generated_samples/snippet_metadata_google.devtools.cloudbuild.v2.json index e05e770..81077ce 100644 --- a/samples/generated_samples/snippet_metadata_google.devtools.cloudbuild.v2.json +++ b/samples/generated_samples/snippet_metadata_google.devtools.cloudbuild.v2.json @@ -8,7 +8,7 @@ ], "language": "PYTHON", "name": "google-cloud-build", - "version": "3.17.0" + "version": "3.17.1" }, "snippets": [ { diff --git a/tests/unit/gapic/cloudbuild_v1/test_cloud_build.py b/tests/unit/gapic/cloudbuild_v1/test_cloud_build.py index 232b3fc..07b1c4c 100644 --- a/tests/unit/gapic/cloudbuild_v1/test_cloud_build.py +++ b/tests/unit/gapic/cloudbuild_v1/test_cloud_build.py @@ -1632,9 +1632,11 @@ async def test_list_builds_async_pages(): RuntimeError, ) pages = [] - async for page_ in ( + # Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch` + # See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372 + async for page_ in ( # pragma: no branch await client.list_builds(request={}) - ).pages: # pragma: no branch + ).pages: pages.append(page_) for page_, token in zip(pages, ["abc", "def", "ghi", ""]): assert page_.raw_page.next_page_token == token @@ -3424,9 +3426,11 @@ async def test_list_build_triggers_async_pages(): RuntimeError, ) pages = [] - async for page_ in ( + # Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch` + # See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372 + async for page_ in ( # pragma: no branch await client.list_build_triggers(request={}) - ).pages: # pragma: no branch + ).pages: pages.append(page_) for page_, token in zip(pages, ["abc", "def", "ghi", ""]): assert page_.raw_page.next_page_token == token @@ -4688,11 +4692,6 @@ def test_get_worker_pool(request_type, transport: str = "grpc"): uid="uid_value", state=cloudbuild.WorkerPool.State.CREATING, etag="etag_value", - private_pool_v1_config=cloudbuild.PrivatePoolV1Config( - worker_config=cloudbuild.PrivatePoolV1Config.WorkerConfig( - machine_type="machine_type_value" - ) - ), ) response = client.get_worker_pool(request) @@ -5839,9 +5838,11 @@ async def test_list_worker_pools_async_pages(): RuntimeError, ) pages = [] - async for page_ in ( + # Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch` + # See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372 + async for page_ in ( # pragma: no branch await client.list_worker_pools(request={}) - ).pages: # pragma: no branch + ).pages: pages.append(page_) for page_, token in zip(pages, ["abc", "def", "ghi", ""]): assert page_.raw_page.next_page_token == token @@ -11130,11 +11131,6 @@ def test_get_worker_pool_rest(request_type): uid="uid_value", state=cloudbuild.WorkerPool.State.CREATING, etag="etag_value", - private_pool_v1_config=cloudbuild.PrivatePoolV1Config( - worker_config=cloudbuild.PrivatePoolV1Config.WorkerConfig( - machine_type="machine_type_value" - ) - ), ) # Wrap the value into a proper Response obj diff --git a/tests/unit/gapic/cloudbuild_v2/test_repository_manager.py b/tests/unit/gapic/cloudbuild_v2/test_repository_manager.py index 718cb16..0e56c35 100644 --- a/tests/unit/gapic/cloudbuild_v2/test_repository_manager.py +++ b/tests/unit/gapic/cloudbuild_v2/test_repository_manager.py @@ -1036,11 +1036,6 @@ def test_get_connection(request_type, transport: str = "grpc"): disabled=True, reconciling=True, etag="etag_value", - github_config=repositories.GitHubConfig( - authorizer_credential=repositories.OAuthCredential( - oauth_token_secret_version="oauth_token_secret_version_value" - ) - ), ) response = client.get_connection(request) @@ -1672,9 +1667,11 @@ async def test_list_connections_async_pages(): RuntimeError, ) pages = [] - async for page_ in ( + # Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch` + # See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372 + async for page_ in ( # pragma: no branch await client.list_connections(request={}) - ).pages: # pragma: no branch + ).pages: pages.append(page_) for page_, token in zip(pages, ["abc", "def", "ghi", ""]): assert page_.raw_page.next_page_token == token @@ -3359,9 +3356,11 @@ async def test_list_repositories_async_pages(): RuntimeError, ) pages = [] - async for page_ in ( + # Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch` + # See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372 + async for page_ in ( # pragma: no branch await client.list_repositories(request={}) - ).pages: # pragma: no branch + ).pages: pages.append(page_) for page_, token in zip(pages, ["abc", "def", "ghi", ""]): assert page_.raw_page.next_page_token == token @@ -4435,9 +4434,11 @@ async def test_fetch_linkable_repositories_async_pages(): RuntimeError, ) pages = [] - async for page_ in ( + # Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch` + # See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372 + async for page_ in ( # pragma: no branch await client.fetch_linkable_repositories(request={}) - ).pages: # pragma: no branch + ).pages: pages.append(page_) for page_, token in zip(pages, ["abc", "def", "ghi", ""]): assert page_.raw_page.next_page_token == token @@ -5082,11 +5083,6 @@ def test_get_connection_rest(request_type): disabled=True, reconciling=True, etag="etag_value", - github_config=repositories.GitHubConfig( - authorizer_credential=repositories.OAuthCredential( - oauth_token_secret_version="oauth_token_secret_version_value" - ) - ), ) # Wrap the value into a proper Response obj