Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

Commit 794de7a

Browse filesBrowse files
gcf-owl-bot[bot]gcf-owl-bot[bot]
authored
fix: Add async context manager return types (#413)
* fix: Add async context manager return types chore: Mock return_value should not populate oneof message fields chore: Support snippet generation for services that only support REST transport chore: Update gapic-generator-python to v1.11.0 PiperOrigin-RevId: 545430278 Source-Link: googleapis/googleapis@601b532 Source-Link: https://github.com/googleapis/googleapis-gen/commit/b3f18d0f6560a855022fd058865e7620479d7af9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 2865a80 commit 794de7a
Copy full SHA for 794de7a

File tree

Expand file treeCollapse file tree

7 files changed

+31
-39
lines changed
Filter options
Expand file treeCollapse file tree

7 files changed

+31
-39
lines changed

‎google/cloud/devtools/cloudbuild_v1/services/cloud_build/async_client.py

Copy file name to clipboardExpand all lines: google/cloud/devtools/cloudbuild_v1/services/cloud_build/async_client.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2682,7 +2682,7 @@ async def sample_list_worker_pools():
26822682
# Done; return the response.
26832683
return response
26842684

2685-
async def __aenter__(self):
2685+
async def __aenter__(self) -> "CloudBuildAsyncClient":
26862686
return self
26872687

26882688
async def __aexit__(self, exc_type, exc, tb):

‎google/cloud/devtools/cloudbuild_v2/services/repository_manager/async_client.py

Copy file name to clipboardExpand all lines: google/cloud/devtools/cloudbuild_v2/services/repository_manager/async_client.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2339,7 +2339,7 @@ async def test_iam_permissions(
23392339
# Done; return the response.
23402340
return response
23412341

2342-
async def __aenter__(self):
2342+
async def __aenter__(self) -> "RepositoryManagerAsyncClient":
23432343
return self
23442344

23452345
async def __aexit__(self, exc_type, exc, tb):

‎google/cloud/devtools/cloudbuild_v2/services/repository_manager/transports/rest.py

Copy file name to clipboardExpand all lines: google/cloud/devtools/cloudbuild_v2/services/repository_manager/transports/rest.py
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2314,7 +2314,7 @@ def __call__(
23142314
request_kwargs = json_format.MessageToDict(request)
23152315
transcoded_request = path_template.transcode(http_options, **request_kwargs)
23162316

2317-
body = json.loads(json.dumps(transcoded_request["body"]))
2317+
body = json.dumps(transcoded_request["body"])
23182318
uri = transcoded_request["uri"]
23192319
method = transcoded_request["method"]
23202320

@@ -2386,7 +2386,7 @@ def __call__(
23862386
request_kwargs = json_format.MessageToDict(request)
23872387
transcoded_request = path_template.transcode(http_options, **request_kwargs)
23882388

2389-
body = json.loads(json.dumps(transcoded_request["body"]))
2389+
body = json.dumps(transcoded_request["body"])
23902390
uri = transcoded_request["uri"]
23912391
method = transcoded_request["method"]
23922392

@@ -2455,7 +2455,7 @@ def __call__(
24552455
request_kwargs = json_format.MessageToDict(request)
24562456
transcoded_request = path_template.transcode(http_options, **request_kwargs)
24572457

2458-
body = json.loads(json.dumps(transcoded_request["body"]))
2458+
body = json.dumps(transcoded_request["body"])
24592459
uri = transcoded_request["uri"]
24602460
method = transcoded_request["method"]
24612461

‎samples/generated_samples/snippet_metadata_google.devtools.cloudbuild.v1.json

Copy file name to clipboardExpand all lines: samples/generated_samples/snippet_metadata_google.devtools.cloudbuild.v1.json
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
],
99
"language": "PYTHON",
1010
"name": "google-cloud-build",
11-
"version": "3.17.0"
11+
"version": "0.1.0"
1212
},
1313
"snippets": [
1414
{

‎samples/generated_samples/snippet_metadata_google.devtools.cloudbuild.v2.json

Copy file name to clipboardExpand all lines: samples/generated_samples/snippet_metadata_google.devtools.cloudbuild.v2.json
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
],
99
"language": "PYTHON",
1010
"name": "google-cloud-build",
11-
"version": "3.17.0"
11+
"version": "0.1.0"
1212
},
1313
"snippets": [
1414
{

‎tests/unit/gapic/cloudbuild_v1/test_cloud_build.py

Copy file name to clipboardExpand all lines: tests/unit/gapic/cloudbuild_v1/test_cloud_build.py
+12-16Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1632,9 +1632,11 @@ async def test_list_builds_async_pages():
16321632
RuntimeError,
16331633
)
16341634
pages = []
1635-
async for page_ in (
1635+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
1636+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
1637+
async for page_ in ( # pragma: no branch
16361638
await client.list_builds(request={})
1637-
).pages: # pragma: no branch
1639+
).pages:
16381640
pages.append(page_)
16391641
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
16401642
assert page_.raw_page.next_page_token == token
@@ -3424,9 +3426,11 @@ async def test_list_build_triggers_async_pages():
34243426
RuntimeError,
34253427
)
34263428
pages = []
3427-
async for page_ in (
3429+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
3430+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
3431+
async for page_ in ( # pragma: no branch
34283432
await client.list_build_triggers(request={})
3429-
).pages: # pragma: no branch
3433+
).pages:
34303434
pages.append(page_)
34313435
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
34323436
assert page_.raw_page.next_page_token == token
@@ -4688,11 +4692,6 @@ def test_get_worker_pool(request_type, transport: str = "grpc"):
46884692
uid="uid_value",
46894693
state=cloudbuild.WorkerPool.State.CREATING,
46904694
etag="etag_value",
4691-
private_pool_v1_config=cloudbuild.PrivatePoolV1Config(
4692-
worker_config=cloudbuild.PrivatePoolV1Config.WorkerConfig(
4693-
machine_type="machine_type_value"
4694-
)
4695-
),
46964695
)
46974696
response = client.get_worker_pool(request)
46984697

@@ -5839,9 +5838,11 @@ async def test_list_worker_pools_async_pages():
58395838
RuntimeError,
58405839
)
58415840
pages = []
5842-
async for page_ in (
5841+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
5842+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
5843+
async for page_ in ( # pragma: no branch
58435844
await client.list_worker_pools(request={})
5844-
).pages: # pragma: no branch
5845+
).pages:
58455846
pages.append(page_)
58465847
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
58475848
assert page_.raw_page.next_page_token == token
@@ -11130,11 +11131,6 @@ def test_get_worker_pool_rest(request_type):
1113011131
uid="uid_value",
1113111132
state=cloudbuild.WorkerPool.State.CREATING,
1113211133
etag="etag_value",
11133-
private_pool_v1_config=cloudbuild.PrivatePoolV1Config(
11134-
worker_config=cloudbuild.PrivatePoolV1Config.WorkerConfig(
11135-
machine_type="machine_type_value"
11136-
)
11137-
),
1113811134
)
1113911135

1114011136
# Wrap the value into a proper Response obj

‎tests/unit/gapic/cloudbuild_v2/test_repository_manager.py

Copy file name to clipboardExpand all lines: tests/unit/gapic/cloudbuild_v2/test_repository_manager.py
+12-16Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1036,11 +1036,6 @@ def test_get_connection(request_type, transport: str = "grpc"):
10361036
disabled=True,
10371037
reconciling=True,
10381038
etag="etag_value",
1039-
github_config=repositories.GitHubConfig(
1040-
authorizer_credential=repositories.OAuthCredential(
1041-
oauth_token_secret_version="oauth_token_secret_version_value"
1042-
)
1043-
),
10441039
)
10451040
response = client.get_connection(request)
10461041

@@ -1672,9 +1667,11 @@ async def test_list_connections_async_pages():
16721667
RuntimeError,
16731668
)
16741669
pages = []
1675-
async for page_ in (
1670+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
1671+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
1672+
async for page_ in ( # pragma: no branch
16761673
await client.list_connections(request={})
1677-
).pages: # pragma: no branch
1674+
).pages:
16781675
pages.append(page_)
16791676
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
16801677
assert page_.raw_page.next_page_token == token
@@ -3359,9 +3356,11 @@ async def test_list_repositories_async_pages():
33593356
RuntimeError,
33603357
)
33613358
pages = []
3362-
async for page_ in (
3359+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
3360+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
3361+
async for page_ in ( # pragma: no branch
33633362
await client.list_repositories(request={})
3364-
).pages: # pragma: no branch
3363+
).pages:
33653364
pages.append(page_)
33663365
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
33673366
assert page_.raw_page.next_page_token == token
@@ -4435,9 +4434,11 @@ async def test_fetch_linkable_repositories_async_pages():
44354434
RuntimeError,
44364435
)
44374436
pages = []
4438-
async for page_ in (
4437+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
4438+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
4439+
async for page_ in ( # pragma: no branch
44394440
await client.fetch_linkable_repositories(request={})
4440-
).pages: # pragma: no branch
4441+
).pages:
44414442
pages.append(page_)
44424443
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
44434444
assert page_.raw_page.next_page_token == token
@@ -5082,11 +5083,6 @@ def test_get_connection_rest(request_type):
50825083
disabled=True,
50835084
reconciling=True,
50845085
etag="etag_value",
5085-
github_config=repositories.GitHubConfig(
5086-
authorizer_credential=repositories.OAuthCredential(
5087-
oauth_token_secret_version="oauth_token_secret_version_value"
5088-
)
5089-
),
50905086
)
50915087

50925088
# Wrap the value into a proper Response obj

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.