Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

chore: clean up type errors in test_api_primitives #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2024
Merged

chore: clean up type errors in test_api_primitives #696

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06179c9
fix: clean up type errors in test_api_primitives
ashleyxuu May 16, 2024
4908637
Merge branch 'main' into ashleyxu-type-errors-api-primitives
ashleyxuu May 16, 2024
71b51e7
Merge branch 'main' into ashleyxu-type-errors-api-primitives
ashleyxuu May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions 8 tests/unit/ml/test_api_primitives.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ def test_base_estimator_repr():
assert estimator.__repr__() == "LinearRegression()"

# TODO(b/340891292): fix type error
estimator = bigframes.ml.decomposition.PCA(n_components=7) # type: ignore
assert estimator.__repr__() == "PCA(n_components=7)"
pca_estimator = bigframes.ml.decomposition.PCA(n_components=7)
assert pca_estimator.__repr__() == "PCA(n_components=7)"


@pytest.mark.skipif(sklearn_linear_model is None, reason="requires sklearn")
Expand All @@ -50,6 +50,6 @@ def test_base_estimator_repr_matches_sklearn():
assert estimator.__repr__() == sklearn_estimator.__repr__()

# TODO(b/340891292): fix type error
estimator = bigframes.ml.decomposition.PCA(n_components=7) # type: ignore
pca_estimator = bigframes.ml.decomposition.PCA(n_components=7)
sklearn_estimator = sklearn_decomposition.PCA(n_components=7)
assert estimator.__repr__() == sklearn_estimator.__repr__()
assert pca_estimator.__repr__() == sklearn_estimator.__repr__()
Morty Proxy This is a proxified and sanitized view of the page, visit original site.