refactor: cache table metadata alongside snapshot time #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures the cached `primary_keys` is more likely to be correct, in case the user called ALTER TABLE after we originally cached the snapshot time.
4 tasks
chelsea-lin
approved these changes
Apr 24, 2024
| cache: Dict[bigquery.TableReference, Tuple[datetime.datetime, bigquery.Table]], | ||
| use_cache: bool = True, | ||
| ) -> Tuple[datetime.datetime, bigquery.Table]: | ||
| cached_table = cache.get(table_ref) |
There was a problem hiding this comment.
nit: if use_cache=False, we can avoid looking through the cache, though the cache won't be too large and the looking is not too expensive.
There was a problem hiding this comment.
Good observation!
Python does dictionary lookups all the time, even for accessing attributes of objects, so I'm not too worried about it. Will leave as-is to avoid the extra nesting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the cached
primary_keysis more likely to be correct, in case the user called ALTER TABLE after we originally cached the snapshot time.Towards internal issue 335727141 and #631
馃