Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

chore: add venv to .gitignore #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

chore: add venv to .gitignore #58

wants to merge 5 commits into from

Conversation

GarrettWu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 25, 2023
@GarrettWu GarrettWu marked this pull request as ready for review September 26, 2023 00:21
@GarrettWu GarrettWu requested review from a team as code owners September 26, 2023 00:21
@GarrettWu GarrettWu requested review from liujiashang and ashleyxuu and removed request for liujiashang September 26, 2023 00:21
@GarrettWu GarrettWu self-assigned this Sep 26, 2023
@product-auto-label product-auto-label bot added size: u Pull request is empty. and removed size: xs Pull request size is extra small. labels Sep 26, 2023
@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 28, 2023
@tswast
Copy link
Collaborator

tswast commented Sep 28, 2023

It is strange that owlbot is reverting the change. Per the commit status of googleapis/synthtool@b79c38d

the gcr.io/repo-automation-bots/owlbot-python:latest image should include this change.

https://pantheon.corp.google.com/cloud-build/builds/c16df434-a4bc-42fe-832b-c28e9b7b26d7;step=1?e=13803378&mods=monitoring_api_prod&project=repo-automation-bots

Note: We use that image here: https://github.com/googleapis/python-bigquery-dataframes/blob/main/.github/.OwlBot.yaml#L16

@GarrettWu
Copy link
Contributor Author

the gcr.io/repo-automation-bots/owlbot-python:latest image should include this change.

The image is built on Aug. 2, that's the reason why?

For now I use github global ignore to bypass the venv folder. https://stackoverflow.com/questions/7335420/global-git-ignore

@tswast
Copy link
Collaborator

tswast commented Oct 3, 2023

Done by #75

@tswast tswast closed this Oct 3, 2023
@GarrettWu GarrettWu deleted the garrettwu-fix branch November 7, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleyxuu ashleyxuu Awaiting requested review from ashleyxuu

Assignees

@GarrettWu GarrettWu

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: u Pull request is empty.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GarrettWu @tswast
Morty Proxy This is a proxified and sanitized view of the page, visit original site.