Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: Inverting int now does bitwise inversion rather than sign flip #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2024
Merged

fix: Inverting int now does bitwise inversion rather than sign flip #574

merged 2 commits into from
Apr 5, 2024

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners April 4, 2024 00:32
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 4, 2024
@TrevorBergeron TrevorBergeron requested review from shobsi and removed request for Genesis929 April 4, 2024 00:32
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Apr 4, 2024
@TrevorBergeron TrevorBergeron merged commit 5f1db8b into main Apr 5, 2024
@TrevorBergeron TrevorBergeron deleted the fix_invert branch April 5, 2024 20:50
@release-please release-please bot mentioned this pull request Apr 5, 2024
Merged
Genesis929 pushed a commit that referenced this pull request Apr 9, 2024
@TrevorBergeron @Genesis929
fix: Inverting int now does bitwise inversion rather than sign flip (#…
46592c0 
…574)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shobsi shobsi shobsi approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrevorBergeron @shobsi
Morty Proxy This is a proxified and sanitized view of the page, visit original site.