Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: allow repr for results more than 10 GB #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
milkshakeiii merged 1 commit into from
Apr 1, 2024
Merged

fix: allow repr for results more than 10 GB #554

milkshakeiii merged 1 commit into from
Apr 1, 2024

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented Apr 1, 2024

Revert "feat: Support max_columns in repr and make repr more efficient"

Reverts #515

@tswast tswast requested review from a team as code owners April 1, 2024 12:19
@tswast tswast requested a review from chelsea-lin April 1, 2024 12:19
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Apr 1, 2024
@tswast tswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 1, 2024
@tswast
Copy link
Collaborator Author

tswast commented Apr 1, 2024

Marking as do not merge until I can understand what's going on. I think it might be that there's no LIMIT in the repr query any more (intentionally so).

@tswast tswast removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 1, 2024
@milkshakeiii milkshakeiii merged commit 9e74154 into main Apr 1, 2024
@milkshakeiii milkshakeiii deleted the revert-515-b329153801-repr branch April 1, 2024 16:12
Genesis929 pushed a commit that referenced this pull request Apr 9, 2024
@tswast @Genesis929
Revert "feat: Support max_columns in repr and make repr more efficient (
6b45547 
#515)" (#554)

This reverts commit 54e49cf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chelsea-lin chelsea-lin Awaiting requested review from chelsea-lin chelsea-lin is a code owner automatically assigned from googleapis/api-bigquery-dataframe

1 more reviewer

@milkshakeiii milkshakeiii milkshakeiii approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@milkshakeiii milkshakeiii

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tswast @milkshakeiii
Morty Proxy This is a proxified and sanitized view of the page, visit original site.