-
Notifications
You must be signed in to change notification settings - Fork 50
feat: Add a unique session_id to Session and allow cleaning up sessions #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
91ec183
feat: Add a unique session_id to Session, allowing manual cleanup of …
milkshakeiii d617ef0
test not closing by default
milkshakeiii faa4c3f
do close in session test for test
milkshakeiii 3e3a47c
skip both tests
milkshakeiii e0029b5
move tests to large and use page size to speed up
milkshakeiii f01416d
skip cleanup in auth failure test
milkshakeiii 6794fe7
fix a doctest
milkshakeiii 06de060
try to fix kokoro e2e
milkshakeiii b11ec2a
only skip one test
milkshakeiii d9cb6d8
skip expensive cleanup in tests
milkshakeiii 3e34042
skip both tests
milkshakeiii 1ddff94
Merge branch 'main' into b331971774-clean-up-tables
milkshakeiii d43398a
don't scan all tables usually
milkshakeiii d66fc57
update comment
milkshakeiii 379622e
update comment
milkshakeiii 9bfa435
Merge branch 'main' into b331971774-clean-up-tables
milkshakeiii a5e48af
update comment
milkshakeiii 9cbbdb1
Update third_party/bigframes_vendored/pandas/core/frame.py
milkshakeiii 96ec88a
Update bigframes/core/global_session.py
milkshakeiii 8462363
Update bigframes/pandas/__init__.py
milkshakeiii db2c809
Update bigframes/session/__init__.py
milkshakeiii b672331
Update bigframes/pandas/__init__.py
milkshakeiii 41b2965
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] cd1925b
Update bigframes/pandas/__init__.py
milkshakeiii 5bb1fe6
Address some of the comments
milkshakeiii 27ee64b
add max_results to list calls and unskip test
milkshakeiii 90dcc31
check for special purpose datasets
milkshakeiii ceff5f3
warn when global session is closed with expired credentials
milkshakeiii 367f78d
use yield fixture to clean up session
milkshakeiii 5a9e687
improve comment
milkshakeiii ebc6522
move slow test to different region
milkshakeiii b517014
Merge branch 'main' into b331971774-clean-up-tables
tswast 34862e2
Update bigframes/core/global_session.py
milkshakeiii 6d0217d
Update bigframes/dataframe.py
milkshakeiii 4dc057b
traceback
milkshakeiii e6a5e45
Merge branch 'main' into b331971774-clean-up-tables
milkshakeiii 5cbb797
Update bigframes/pandas/__init__.py
milkshakeiii 179f2c4
Merge branch 'main' into b331971774-clean-up-tables
milkshakeiii d222536
Merge branch 'main' into b331971774-clean-up-tables
milkshakeiii f9e2888
don't scan datasets
milkshakeiii 7e8acd7
change default param behavior
milkshakeiii e422cd3
try 10000 max results
milkshakeiii 0421509
Merge branch 'main' into b331971774-clean-up-tables
milkshakeiii 1ce15ac
format fix
milkshakeiii d0aff59
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 10cada8
Merge branch 'b331971774-clean-up-tables' of https://github.com/googl…
gcf-owl-bot[bot] 1551354
still use alternative region
milkshakeiii ed2bf70
Merge branch 'main' into b331971774-clean-up-tables
milkshakeiii 529e015
Update bigframes/pandas/__init__.py
milkshakeiii 6fda625
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 75c7cae
Merge branch 'main' into b331971774-clean-up-tables
milkshakeiii deebc64
address some of the comments
milkshakeiii 66f014c
docstring fix
milkshakeiii c827465
add warning
milkshakeiii 07fe6b3
don't use global session in test_clean_up_by_session_id
milkshakeiii 76f73fa
Update bigframes/pandas/__init__.py
tswast 3669d97
Merge branch 'main' into b331971774-clean-up-tables
tswast ac24209
avoid possible changing global session
milkshakeiii c1c11f6
Merge branch 'main' into b331971774-clean-up-tables
milkshakeiii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.