Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: label query jobs with an bigframes-api-xx key indicating the Python API(s) used to construct it #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

feat: label query jobs with an bigframes-api-xx key indicating the Python API(s) used to construct it #55

wants to merge 11 commits into from

Conversation

ashleyxuu
Copy link
Contributor

Change-Id: I2a201ff6f35e4c945177b2f504b60a3744e86a0d

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ashleyxuu ashleyxuu requested review from a team as code owners September 22, 2023 22:06
@ashleyxuu ashleyxuu requested a review from tswast September 22, 2023 22:06
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 22, 2023
@ashleyxuu ashleyxuu force-pushed the ashleyxu-add-api-name branch from 22ca508 to 6f94f6f Compare September 22, 2023 22:13
@ashleyxuu ashleyxuu force-pushed the ashleyxu-add-api-name branch from b69b507 to 042045c Compare September 23, 2023 15:59
TrevorBergeron
TrevorBergeron requested changes Sep 26, 2023
View reviewed changes
bigframes/core/__init__.py Outdated Show resolved Hide resolved
bigframes/core/__init__.py Outdated Show resolved Hide resolved
tswast
tswast requested changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feat: seems an odd classification. This isn't a new feature as far as end user's are concerned, right? It doesn't allow them to do anything new.

bigframes/core/__init__.py Outdated Show resolved Hide resolved
bigframes/core/__init__.py Outdated Show resolved Hide resolved
bigframes/session.py Outdated Show resolved Hide resolved
@ashleyxuu ashleyxuu force-pushed the ashleyxu-add-api-name branch from 17f0d53 to db6f29c Compare September 27, 2023 23:29
@tswast tswast changed the title feat: add more api_name in job config feat: label query jobs with an bigframes-api-xx key indicating the Python API(s) used to construct it Sep 28, 2023
tswast
tswast requested changes Sep 28, 2023
View reviewed changes
bigframes/core/__init__.py Outdated Show resolved Hide resolved
bigframes/core/__init__.py Outdated Show resolved Hide resolved
bigframes/core/__init__.py Outdated Show resolved Hide resolved
bigframes/core/__init__.py Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Sep 28, 2023
tswast
tswast requested changes Oct 2, 2023
View reviewed changes
bigframes/session.py Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. size: l Pull request size is large. and removed size: l Pull request size is large. size: xl Pull request size is extra large. labels Oct 3, 2023
tswast
tswast reviewed Oct 3, 2023
View reviewed changes
bigframes/core/io.py Outdated Show resolved Hide resolved
bigframes/core/io.py Outdated Show resolved Hide resolved
bigframes/core/io.py Outdated Show resolved Hide resolved
tests/unit/core/test_io.py Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Oct 3, 2023
@ashleyxuu ashleyxuu force-pushed the ashleyxu-add-api-name branch from b9eda76 to ca17ccf Compare October 4, 2023 03:19
@ashleyxuu ashleyxuu mentioned this pull request Oct 26, 2023
Merged
4 tasks
@tswast
Copy link
Collaborator

tswast commented Dec 12, 2023

Closing in favor of the approach in #145

@tswast tswast closed this Dec 12, 2023
@tswast tswast deleted the ashleyxu-add-api-name branch April 1, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast requested changes

@TrevorBergeron TrevorBergeron TrevorBergeron requested changes

Assignees

@tswast tswast

@ashleyxuu ashleyxuu

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashleyxuu @tswast @TrevorBergeron
Morty Proxy This is a proxified and sanitized view of the page, visit original site.