Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

chore: add ml_fundamentals_bq_dataframes.ipynb to denylist. #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2024
Merged

chore: add ml_fundamentals_bq_dataframes.ipynb to denylist. #325

merged 1 commit into from
Jan 18, 2024

Conversation

Genesis929
Copy link
Collaborator

@Genesis929 Genesis929 commented Jan 17, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Notebook contains a variable that requires a value but value is not set, can't run directly, shouldn't be tested. This fixes e2e test error.

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 17, 2024
@Genesis929 Genesis929 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 17, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 17, 2024
@Genesis929 Genesis929 requested a review from ashleyxuu January 18, 2024 00:38
@Genesis929 Genesis929 marked this pull request as ready for review January 18, 2024 00:38
@Genesis929 Genesis929 requested review from a team as code owners January 18, 2024 00:38
@Genesis929 Genesis929 merged commit f45c078 into main Jan 18, 2024
@Genesis929 Genesis929 deleted the huanc-notebook-fix branch January 18, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleyxuu ashleyxuu Awaiting requested review from ashleyxuu

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Genesis929 @ashleyxuu
Morty Proxy This is a proxified and sanitized view of the page, visit original site.