Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

chore: Move polars_session.py to bigframes/testing module #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

chore: Move polars_session.py to bigframes/testing module #1760

merged 1 commit into from
May 21, 2025

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 21, 2025
@TrevorBergeron TrevorBergeron requested a review from tswast May 21, 2025 20:45
@TrevorBergeron TrevorBergeron marked this pull request as ready for review May 21, 2025 20:45
@TrevorBergeron TrevorBergeron requested review from a team as code owners May 21, 2025 20:45
tswast
tswast approved these changes May 21, 2025
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

@tswast tswast merged commit ea713bf into main May 21, 2025
15 of 23 checks passed
@tswast tswast deleted the session_test_move branch May 21, 2025 21:57
@tswast
Copy link
Collaborator

tswast commented May 21, 2025 •
edited
Loading

I used my admin privileges to merge because this change only affects unit tests and unit tests are passing. It would be great to have this in this week's release so it makes it to google3 sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees

@jialuoo jialuoo

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrevorBergeron @tswast @jialuoo
Morty Proxy This is a proxified and sanitized view of the page, visit original site.