-
Notifications
You must be signed in to change notification settings - Fork 49
test: Add dataframe unit test suite #1751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
34ae742
to
e8baa7d
Compare
@@ -0,0 +1,4481 @@ | ||
# Copyright 2023 Google LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this file contain context same as tests/system/small/test_dataframe.py
? If so, can we reduce code redundancy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a slightly smaller set of tests (maybe like 80% of them?) with some slightly modified validations (eg, stop counting executions). Can unify, but goal is to eventually delete the system test versions of these tests.
5fc1913
to
4c4d939
Compare
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕