Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: set vscode and jupyter environments in the BQ jobs #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 27, 2025

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Mar 24, 2025

BEGIN_COMMIT_OVERRIDE
chore: instrument vscode and jupyter environments in the BQ jobs (#1527)
END_COMMIT_OVERRIDE

In this change we are including the vscode and jupyter environments in the application name set in the BigQuery jobs. This would help understand the BigFrames usage coming from those environments. Here is demo of various scenarios: screen/5VkX8yp9S7PTzBv

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 398019864 🦕

In this change we are including the vscode and jupyter environments in
the application name set in the BigQuery jobs. This would help
understand the BigFrames usage coming from those environments.
@shobsi shobsi requested review from a team as code owners March 24, 2025 17:24
@shobsi shobsi requested a review from jialuoo March 24, 2025 17:24
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 24, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Mar 24, 2025
bigframes/session/environment.py Outdated Show resolved Hide resolved
bigframes/session/environment.py Outdated Show resolved Hide resolved
bigframes/session/environment.py Outdated Show resolved Hide resolved
bigframes/session/environment.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jialuoo jialuoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are failing. Please investigate it.

@shobsi shobsi requested review from tswast and Genesis929 March 27, 2025 00:49
@shobsi shobsi merged commit 9948013 into main Mar 27, 2025
24 checks passed
@shobsi shobsi deleted the shobs-instrument-ide branch March 27, 2025 05:47
shobsi added a commit that referenced this pull request Mar 28, 2025
* feat: set vscode and jupyter environments in the BQ jobs

In this change we are including the vscode and jupyter environments in
the application name set in the BigQuery jobs. This would help
understand the BigFrames usage coming from those environments.

* remove print, overlook all exceptions during extension detection

* slight formatting fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.