Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

docs: update GeoSeries.difference() and bigframes.bigquery.st_difference() docs #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 25, 2025
Merged

docs: update GeoSeries.difference() and bigframes.bigquery.st_difference() docs #1526

merged 6 commits into from
Mar 25, 2025

Conversation

arwas11
Copy link
Contributor

@arwas11 arwas11 commented Mar 24, 2025 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
    • difference: screen/p6wtJLPa9ebR8bJ, screen/4RqGh6Pyru6aMCr, screen/C3Si6U97PhuGdbx, screen/87EqhxARU5XHGhV
    • st_difference: screen/8KoAcYitnbf4zyb, screen/Wjy2s3y7Ne5PHRZ, screen/AKwQUj6hMiHvHsu, screen/8FMjy2Jfq38uEH5

Fixes #400711766 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 24, 2025
@arwas11 arwas11 marked this pull request as ready for review March 24, 2025 17:22
@arwas11 arwas11 requested review from a team as code owners March 24, 2025 17:22
@arwas11 arwas11 requested a review from chelsea-lin March 24, 2025 17:22
chelsea-lin
chelsea-lin requested changes Mar 24, 2025
View reviewed changes
third_party/bigframes_vendored/geopandas/geoseries.py Outdated Show resolved Hide resolved
third_party/bigframes_vendored/geopandas/geoseries.py Outdated Show resolved Hide resolved
@arwas11
Copy link
Contributor Author

arwas11 commented Mar 24, 2025

Unrelated notebook failure

=========================== short test summary info ============================
FAILED notebooks/generative_ai/large_language_models.ipynb::large_language_models.ipynb

@arwas11 arwas11 requested a review from chelsea-lin March 24, 2025 18:29
chelsea-lin
chelsea-lin approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arwas11 arwas11 enabled auto-merge (squash) March 25, 2025 15:59
@arwas11 arwas11 merged commit d553fa2 into main Mar 25, 2025
17 of 24 checks passed
@arwas11 arwas11 deleted the b400711766-geo-difference-docs branch March 25, 2025 16:25
@release-please release-please bot mentioned this pull request Mar 25, 2025
Merged
shobsi pushed a commit that referenced this pull request Mar 28, 2025
@arwas11 @shobsi
docs: update GeoSeries.difference() and `bigframes.bigquery.st_diff…
85801e6 
…erence()` docs (#1526)

* docs: update GeoSeries.difference() and bigframes.bigquery.st_difference() docs

* update variable names for readability
@release-please release-please bot mentioned this pull request Mar 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

Assignees

@jialuoo jialuoo

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arwas11 @chelsea-lin @jialuoo
Morty Proxy This is a proxified and sanitized view of the page, visit original site.