-
Notifications
You must be signed in to change notification settings - Fork 49
refactor: introduce ai operator namespace and deprecated semantics #1511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ff31b7e
refactor: introduce ai operator namespace and deprecated semantics
sycai a9b2776
Merge branch 'main' into sycai_ai_ops
sycai df640c2
duplicate semantic op options too
sycai 1bb3d6f
Merge branch 'main' into sycai_ai_ops
sycai 5db0d33
improve test coverage
sycai 238d098
relax test condition
sycai fdd36ad
Merge branch 'main' into sycai_ai_ops
sycai db59f44
Merge branch 'main' into sycai_ai_ops
sycai 2a70886
Merge branch 'main' into sycai_ai_ops
sycai f7625ac
Merge branch 'main' into sycai_ai_ops
sycai bcb5bcf
clean up semantics and add public docs
sycai 20b4cfe
addressing comments
sycai fd37607
use FutureWarning for deprecation
sycai befd87a
Merge branch 'main' into sycai_ai_ops
sycai 1b1fce8
Merge branch 'main' into sycai_ai_ops
sycai 6ae8dfe
copy over recent top_k changes
sycai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -74,6 +74,7 @@ | |
import bigframes.operations as ops | ||
import bigframes.operations.aggregations | ||
import bigframes.operations.aggregations as agg_ops | ||
import bigframes.operations.ai | ||
import bigframes.operations.plotting as plotting | ||
import bigframes.operations.semantics | ||
import bigframes.operations.structs | ||
|
@@ -4574,4 +4575,13 @@ def _throw_if_null_index(self, opname: str): | |
|
||
@property | ||
def semantics(self): | ||
msg = bfe.format_message( | ||
"The 'semantics' property will be removed. Please use 'ai' instead." | ||
) | ||
warnings.warn(msg, category=FutureWarning) | ||
return bigframes.operations.semantics.Semantics(self) | ||
|
||
@property | ||
def ai(self): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this need a docstring? Also, please add the as well as thhe table of contents
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
"""Returns the accessor for AI operators.""" | ||
return bigframes.operations.ai.AIAccessor(self) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also update the docstring as the semantic ops here. Also, mark semantic_ops as deprecated in the docstring too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done