Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

chore: Finish factoring unit tests from presubmit #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 30, 2025
+15 −4
Merged

chore: Finish factoring unit tests from presubmit #1492

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ce60c61
chore: Finish factoring unit tests from presubmit
TrevorBergeron Mar 13, 2025
69027d9
adjust cover requirement to 83
TrevorBergeron Mar 14, 2025
783f6b7
Merge branch 'main' into unit_in_system
TrevorBergeron Mar 19, 2025
3105feb
Merge remote-tracking branch 'github/main' into unit_in_system
TrevorBergeron May 30, 2025
dc0cf0e
add back test directory coverage
TrevorBergeron May 30, 2025
be826ea
ignore some non-prod directories for coverage
TrevorBergeron May 30, 2025
7b92a86
amend omit arg in cover to work properly
TrevorBergeron May 30, 2025
39b76fc
reduce cov threshold to 84
TrevorBergeron May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions 19 noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,10 @@
# Sessions are executed in the order so putting the smaller sessions
# ahead to fail fast at presubmit running.
nox.options.sessions = [
"unit",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because it's redundant with GitHub Actions, right?

Doesn't look like

python-bigquery-dataframes/.github/workflows/unittest.yml

Line 61 in bd07e05

coverage report --show-missing --fail-under=35
actually uses nox for the coverage step, so that's probably okay to just be system tests.

"system-3.9",
"system-3.12",
"cover",
# TODO(b/401609005): remove
"cleanup",
]

Expand Down Expand Up @@ -471,20 +471,31 @@ def cover(session):
session.install("coverage", "pytest-cov")

# Create a coverage report that includes only the product code.
omitted_paths = [
# non-prod, unit tested
"bigframes/core/compile/polars/*",
"bigframes/core/compile/sqlglot/*",
# untested
"bigframes/streaming/*",
# utils
"bigframes/testing/*",
]

session.run(
"coverage",
"report",
"--include=bigframes/*",
# Only unit tested
f"--omit={','.join(omitted_paths)}",
"--show-missing",
"--fail-under=85",
"--fail-under=84",
)

# Make sure there is no dead code in our test directories.
# Make sure there is no dead code in our system test directories.
session.run(
"coverage",
"report",
"--show-missing",
"--include=tests/unit/*",
"--include=tests/system/small/*",
# TODO(b/353775058) resume coverage to 100 when the issue is fixed.
"--fail-under=99",
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.