Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

test: target e2e tests to python 3.11 for max coverage #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 11, 2025
Merged

test: target e2e tests to python 3.11 for max coverage #1474

merged 7 commits into from
Mar 11, 2025

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Mar 7, 2025 •
edited
Loading

BEGIN_COMMIT_OVERRIDE
test: target e2e tests to python 3.11 for max coverage (#1474)

chore: remove version 1.x guard to surface version 2.0 FutureWarning (#1474)
END_COMMIT_OVERRIDE

Cloud Run Functions supports Python versions up to 3.12 - https://cloud.google.com/run/docs/runtimes/python.
Managed Python UDF is supported only in Python 3.11. Let's set the E2E tests version to 3.11 to cover most code paths.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 401318988 🦕

@shobsi shobsi requested review from a team as code owners March 7, 2025 23:25
@shobsi shobsi requested a review from Genesis929 March 7, 2025 23:25
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 7, 2025
@jialuoo jialuoo self-requested a review March 7, 2025 23:51
jialuoo
jialuoo reviewed Mar 8, 2025
View reviewed changes
tests/system/large/functions/test_managed_function.py Show resolved Hide resolved
@shobsi shobsi changed the title test: target e2e tests to python 3.12 for max coverage test: target e2e tests to python 3.11 for max coverage Mar 10, 2025
@tswast
Copy link
Collaborator

tswast commented Mar 10, 2025

@shobsi It looks like you need to resolve some merge conflicts before merging.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Mar 11, 2025
@shobsi shobsi merged commit 9e471fb into main Mar 11, 2025
23 checks passed
@shobsi shobsi deleted the shobs-force-e2e-py311 branch March 11, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Genesis929 Genesis929 Genesis929 approved these changes

@jialuoo jialuoo jialuoo approved these changes

Assignees

@tswast tswast

@jialuoo jialuoo

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shobsi @tswast @Genesis929 @jialuoo
Morty Proxy This is a proxified and sanitized view of the page, visit original site.