Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

chore: fix Multimodal Gemini modifies input DF #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 7, 2025
Merged

Conversation

GarrettWu
Copy link
Contributor

Think it is consistent for output after converting. That modifying converted object doesn't affect the original one.

@GarrettWu GarrettWu requested a review from sycai March 6, 2025 20:59
@GarrettWu GarrettWu self-assigned this Mar 6, 2025
@GarrettWu GarrettWu requested review from a team as code owners March 6, 2025 20:59
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 6, 2025
Copy link
Contributor

@sycai sycai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, do we really need to make a copy? DataFrames and Series are inherently immutable, right?

Are you seeing errors when the converter returns the original object instead of the copy?

@GarrettWu
Copy link
Contributor Author

Hmmm, do we really need to make a copy? DataFrames and Series are inherently immutable, right?

Are you seeing errors when the converter returns the original object instead of the copy?

No, they are mutable. E.g. assign df["a"] = 1

@GarrettWu GarrettWu enabled auto-merge (squash) March 7, 2025 00:29
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 7, 2025
@GarrettWu GarrettWu merged commit 9a65e83 into main Mar 7, 2025
23 checks passed
@GarrettWu GarrettWu deleted the garrettwu-fix branch March 7, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.