chore: Cleanup kokoro artifacts at end of build #1462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
reviewed
Mar 6, 2025
| @@ -50,3 +50,6 @@ if [[ -n "${NOX_SESSION:-}" ]]; then | ||
| else | ||
| python3 -m nox --stop-on-first-error | ||
| fi | ||
|
|
||
| # Prevent kokoro from trying to collect many mb of artifacts, wasting several minutes | ||
| sudo rm -rf "${KOKORO_ARTIFACTS_DIR?}"/* |
There was a problem hiding this comment.
I worry that this might break the release build. Could you check?
Also, I recall there is a https://github.com/googleapis/repo-automation-bots/tree/main/packages/flakybot that could use these to automatically file issues for which specific tests are being flaky. It was in the list of TODOs when we first setup the repo, but I don't think we ever got around to setting it up.
There was a problem hiding this comment.
From what I can see, release build uses release.sh for its build file. Flakybot seems to be independent of post-build artifact collection, and is only invoked from samples tests it seems.
tswast
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕