Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

chore: format warning message with newlines and ansi color #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 6, 2025
Merged

chore: format warning message with newlines and ansi color #1447

merged 4 commits into from
Mar 6, 2025

Conversation

chelsea-lin
Copy link
Contributor

@chelsea-lin chelsea-lin commented Mar 3, 2025 •
edited
Loading

This change format warning messages with newlines and ansi color. With this change, example warning messages would look likes: https://screenshot.googleplex.com/6BWEKC59HETv9F2

  • Fixes internal issue 400400035
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 400400035 🦕

@chelsea-lin chelsea-lin requested a review from tswast March 3, 2025 23:41
@chelsea-lin chelsea-lin requested review from a team as code owners March 3, 2025 23:42
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 3, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Mar 3, 2025
tswast
tswast approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like there's some merge conflicts to resolve, but these changes LGTM to me.

@chelsea-lin chelsea-lin force-pushed the main_chelsealin_warningmessage branch 2 times, most recently from 1623d23 to 3c8b70d Compare March 5, 2025 23:33
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Mar 5, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_warningmessage branch from 3c8b70d to 58242bb Compare March 5, 2025 23:36
@chelsea-lin chelsea-lin enabled auto-merge (squash) March 5, 2025 23:37
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_warningmessage branch from 58242bb to cfa5d3e Compare March 6, 2025 00:24
@chelsea-lin chelsea-lin merged commit 7b0cab5 into main Mar 6, 2025
22 of 23 checks passed
@chelsea-lin chelsea-lin deleted the main_chelsealin_warningmessage branch March 6, 2025 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees

@ericfe-google ericfe-google

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chelsea-lin @tswast @ericfe-google
Morty Proxy This is a proxified and sanitized view of the page, visit original site.