From f4f3f2219dd275c94db6dbb2eb2a7a4e5ac53412 Mon Sep 17 00:00:00 2001 From: Shenyang Cai Date: Fri, 21 Feb 2025 21:09:07 +0000 Subject: [PATCH 1/2] fix: replace empty dict wit None to avoid mutable default arguments --- bigframes/core/schema.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bigframes/core/schema.py b/bigframes/core/schema.py index e3808dfffd..f357462a02 100644 --- a/bigframes/core/schema.py +++ b/bigframes/core/schema.py @@ -41,8 +41,10 @@ class ArraySchema: def from_bq_table( cls, table: google.cloud.bigquery.Table, - column_type_overrides: typing.Dict[str, bigframes.dtypes.Dtype] = {}, + column_type_overrides: typing.Optional[typing.Dict[str, bigframes.dtypes.Dtype]] = None, ): + if column_type_overrides is None: + column_type_overrides = {} items = tuple( SchemaItem(name, column_type_overrides.get(name, dtype)) for name, dtype in bigframes.dtypes.bf_type_from_type_kind( From 9bed44fb793ad432b0e1b6384bf663a8ea7fac13 Mon Sep 17 00:00:00 2001 From: Shenyang Cai Date: Fri, 21 Feb 2025 21:10:27 +0000 Subject: [PATCH 2/2] fix format --- bigframes/core/schema.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bigframes/core/schema.py b/bigframes/core/schema.py index f357462a02..c379db72be 100644 --- a/bigframes/core/schema.py +++ b/bigframes/core/schema.py @@ -41,7 +41,9 @@ class ArraySchema: def from_bq_table( cls, table: google.cloud.bigquery.Table, - column_type_overrides: typing.Optional[typing.Dict[str, bigframes.dtypes.Dtype]] = None, + column_type_overrides: typing.Optional[ + typing.Dict[str, bigframes.dtypes.Dtype] + ] = None, ): if column_type_overrides is None: column_type_overrides = {}