Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: add GeoSeries.from_wkt() and GeoSeries.to_wkt() #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 20, 2025
Merged

feat: add GeoSeries.from_wkt() and GeoSeries.to_wkt() #1401

merged 15 commits into from
Feb 20, 2025

Conversation

arwas11
Copy link
Contributor

@arwas11 arwas11 commented Feb 14, 2025 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
    • 'from_wkt': screen/8SCTw8XmxoenFSM, screen/6SWbgHfxx4G2ptR
    • 'to_wkt': screen/BNpwGwmGC5dCjPY, screen/AaFYtvpWUJA5nkZ

Fixes #396675129 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Feb 14, 2025
tswast
tswast reviewed Feb 14, 2025
View reviewed changes
third_party/bigframes_vendored/geopandas/geoseries.py Outdated Show resolved Hide resolved
tswast
tswast reviewed Feb 14, 2025
View reviewed changes
bigframes/geopandas/geoseries.py Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Feb 14, 2025
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@arwas11 arwas11 marked this pull request as ready for review February 19, 2025 21:27
@arwas11 arwas11 requested review from a team as code owners February 19, 2025 21:27
@arwas11 arwas11 requested a review from tswast February 19, 2025 21:27
tswast
tswast approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bigframes/bigquery/_operations/geo.py Outdated Show resolved Hide resolved
bigframes/core/compile/scalar_op_compiler.py Outdated Show resolved Hide resolved
@tswast tswast enabled auto-merge (squash) February 20, 2025 16:25
@tswast tswast merged commit 2993b28 into main Feb 20, 2025
22 of 23 checks passed
@tswast tswast deleted the b308738592-geopandas-st_geogfromtext branch February 20, 2025 17:32
@release-please release-please bot mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees

@rey-esp rey-esp

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arwas11 @tswast @rey-esp
Morty Proxy This is a proxified and sanitized view of the page, visit original site.