perf: Improve isin performance #1203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
approved these changes
Jan 29, 2025
bigframes/core/nodes.py
Outdated
| @@ -284,6 +290,24 @@ def prune(self, used_cols: COLUMN_SET) -> BigFrameNode: | ||
| return self.transform_children(lambda x: x.prune(used_cols)) | ||
|
|
||
|
|
||
| class AdditiveNode: | ||
| """Definition of additive - if you drop added_fields, you end up with the descendent.""" |
There was a problem hiding this comment.
A picture might help :-)
Suggested change
| """Definition of additive - if you drop added_fields, you end up with the descendent.""" | |
| """Definition of additive - if you drop added_fields, you end up with the descendent. | |
| .. code-block:: text | |
| AdditiveNode (fields: a, b, c; added_fields: c) | |
| | | |
| | additive_base | |
| V | |
| BigFrameNode (fields: a, b) | |
| """ |
See https://stackoverflow.com/a/50956831/101923 for creating a plain text block
Comment on lines
+480
to
+481
| def replace_additive_base(self, node: BigFrameNode): | ||
| return dataclasses.replace(self, left_child=node) |
There was a problem hiding this comment.
Thinking aloud: I wonder if there's some way we can organize these sorts of tree transformations so that it's easier to reason about which can be applied in which order?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕