Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

refactor: Add function to make all column ids in a tree unique and sequential #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Nov 5, 2024

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 17, 2024
@TrevorBergeron TrevorBergeron changed the title Remap vars refactor: Add function to make all column ids in a tree unique and sequential Oct 18, 2024
@TrevorBergeron TrevorBergeron added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 29, 2024
@TrevorBergeron TrevorBergeron marked this pull request as ready for review October 29, 2024 17:23
@TrevorBergeron TrevorBergeron requested review from a team as code owners October 29, 2024 17:23
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some tests to increase the test coverages on these core files. Thanks!
The following link is the current coverage status:
https://fusion2.corp.google.com/ci/kokoro/prod:bigframes%2Fpresubmit%2Fpresubmit/activity/88a8d1da-2043-4a7a-8ae8-0b91d7e51c84/log

@@ -3472,6 +3472,52 @@ def _apply_unary_op(self, operation: ops.UnaryOp) -> DataFrame:
block = self._block.multi_apply_unary_op(self._block.value_columns, operation)
return DataFrame(block)

def f(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, it's internal function. Maybe _f or other more readable name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see this method gets called. Please double check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accidentally copied _map_clustering_columns removed in new revision

@TrevorBergeron
Copy link
Contributor Author

Could you please add some tests to increase the test coverages on these core files. Thanks! The following link is the current coverage status: https://fusion2.corp.google.com/ci/kokoro/prod:bigframes%2Fpresubmit%2Fpresubmit/activity/88a8d1da-2043-4a7a-8ae8-0b91d7e51c84/log

increasing code coverage is definitely a goal, however the code in this PR is covered (minus assert code that should never hit).

@TrevorBergeron TrevorBergeron removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 5, 2024
@TrevorBergeron TrevorBergeron merged commit e7fa913 into main Nov 5, 2024
22 of 23 checks passed
@TrevorBergeron TrevorBergeron deleted the remap_vars branch November 5, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.