refactor: Add function to make all column ids in a tree unique and sequential #1094
Conversation
There was a problem hiding this comment.
Could you please add some tests to increase the test coverages on these core files. Thanks!
The following link is the current coverage status:
https://fusion2.corp.google.com/ci/kokoro/prod:bigframes%2Fpresubmit%2Fpresubmit/activity/88a8d1da-2043-4a7a-8ae8-0b91d7e51c84/log
bigframes/dataframe.py
Outdated
| @@ -3472,6 +3472,52 @@ def _apply_unary_op(self, operation: ops.UnaryOp) -> DataFrame: | ||
| block = self._block.multi_apply_unary_op(self._block.value_columns, operation) | ||
| return DataFrame(block) | ||
|
|
||
| def f( |
There was a problem hiding this comment.
IIUC, it's internal function. Maybe _f or other more readable name.
There was a problem hiding this comment.
I didn't see this method gets called. Please double check.
There was a problem hiding this comment.
accidentally copied _map_clustering_columns removed in new revision
increasing code coverage is definitely a goal, however the code in this PR is covered (minus assert code that should never hit). |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕