Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

docs: update docstrings of DataFrame and related files #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 24, 2024
Merged

docs: update docstrings of DataFrame and related files #1092

merged 10 commits into from
Oct 24, 2024

Conversation

arwas11
Copy link
Contributor

@arwas11 arwas11 commented Oct 17, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #296390934 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 17, 2024
@arwas11 arwas11 requested a review from tswast October 17, 2024 17:09
tswast
tswast reviewed Oct 17, 2024
View reviewed changes
bigframes/dataframe.py Outdated Show resolved Hide resolved
third_party/bigframes_vendored/pandas/core/frame.py Outdated Show resolved Hide resolved
third_party/bigframes_vendored/pandas/core/generic.py Outdated Show resolved Hide resolved
@arwas11 arwas11 requested a review from tswast October 21, 2024 16:16
@arwas11 arwas11 marked this pull request as ready for review October 22, 2024 14:51
@arwas11 arwas11 requested review from a team as code owners October 22, 2024 14:51
@arwas11 arwas11 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 22, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 22, 2024
tswast
tswast reviewed Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Otherwise, looking good. Thanks!

bigframes/dataframe.py Outdated Show resolved Hide resolved
third_party/bigframes_vendored/pandas/core/frame.py Outdated Show resolved Hide resolved
third_party/bigframes_vendored/pandas/core/generic.py Outdated Show resolved Hide resolved
third_party/bigframes_vendored/pandas/core/generic.py Outdated Show resolved Hide resolved
@arwas11 arwas11 requested a review from tswast October 23, 2024 15:55
tswast
tswast reviewed Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my previous feedback. A few more nits.

bigframes/dataframe.py Outdated Show resolved Hide resolved
third_party/bigframes_vendored/pandas/core/frame.py Outdated Show resolved Hide resolved
third_party/bigframes_vendored/pandas/core/frame.py Outdated Show resolved Hide resolved
third_party/bigframes_vendored/pandas/core/frame.py Outdated Show resolved Hide resolved
third_party/bigframes_vendored/pandas/core/generic.py Outdated Show resolved Hide resolved
@tswast tswast merged commit 15e9fd5 into main Oct 24, 2024
17 of 23 checks passed
@tswast tswast deleted the b296390934-docstring-type-annotation branch October 24, 2024 14:12
@release-please release-please bot mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees

@GarrettWu GarrettWu

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arwas11 @tswast @GarrettWu
Morty Proxy This is a proxified and sanitized view of the page, visit original site.