fix: send BigQuery cancel request when canceling bigframes process #103
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -153,6 +153,11 @@ def wait_for_query_job( | |
| except api_core_exceptions.GoogleAPICallError as exc: | ||
| add_feedback_link(exc) | ||
| raise | ||
| except KeyboardInterrupt: | ||
| query_job.cancel() | ||
| print(f"Requested cancelation for {query_job.job_type} {query_job.job_id}...") | ||
|
There was a problem hiding this comment. Thanks Shobhit, created #111 to address these. |
||
| # begin the cancel request before immediately rethrowing | ||
| raise | ||
|
|
||
|
|
||
| def wait_for_job(job: GenericJob, progress_bar: Optional[str] = None): | ||
|
|
@@ -190,6 +195,11 @@ def wait_for_job(job: GenericJob, progress_bar: Optional[str] = None): | |
| except api_core_exceptions.GoogleAPICallError as exc: | ||
| add_feedback_link(exc) | ||
| raise | ||
| except KeyboardInterrupt: | ||
| job.cancel() | ||
| print(f"Requested cancelation for {job.job_type} {job.job_id}...") | ||
|
There was a problem hiding this comment. We may like to follow the following pattern done elsewhere for consistency:
There was a problem hiding this comment. Thanks Shobhit, created #111 to address these. |
||
| # begin the cancel request before immediately rethrowing | ||
| raise | ||
|
|
||
|
|
||
| def get_job_url(query_job: GenericJob): | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda nitpick - English vocab is not my forte but I wondered about "cancelation" vs "cancellation" and looks like in
googleapisrepos the former is a rarity, the latter is commonly used.