Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: improve robustness of managed udf code extraction #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 22, 2025
Merged

fix: improve robustness of managed udf code extraction #1634

merged 5 commits into from
Apr 22, 2025

Conversation

jialuoo
Copy link
Contributor

@jialuoo jialuoo commented Apr 18, 2025

Fix the issue in b/409571106.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Apr 18, 2025
@jialuoo jialuoo requested a review from shobsi April 18, 2025 18:52
@jialuoo jialuoo marked this pull request as ready for review April 18, 2025 18:52
@jialuoo jialuoo requested review from a team as code owners April 18, 2025 18:52
shobsi
shobsi reviewed Apr 21, 2025
View reviewed changes
bigframes/functions/_function_client.py Show resolved Hide resolved
shobsi
shobsi reviewed Apr 21, 2025
View reviewed changes
bigframes/functions/_function_client.py Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Apr 22, 2025
@jialuoo jialuoo requested a review from shobsi April 22, 2025 00:32
shobsi
shobsi reviewed Apr 22, 2025
View reviewed changes
tests/system/large/functions/test_managed_function.py Outdated Show resolved Hide resolved
@jialuoo jialuoo enabled auto-merge (squash) April 22, 2025 04:58
@jialuoo jialuoo merged commit 8cc56d5 into main Apr 22, 2025
18 of 24 checks passed
@jialuoo jialuoo deleted the fix-udf-code branch April 22, 2025 05:25
@release-please release-please bot mentioned this pull request Apr 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shobsi shobsi shobsi approved these changes

@shuoweil shuoweil shuoweil approved these changes

Assignees

@shuoweil shuoweil

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jialuoo @shobsi @shuoweil
Morty Proxy This is a proxified and sanitized view of the page, visit original site.