-
Notifications
You must be signed in to change notification settings - Fork 50
docs: include all licenses for vendored packages in the root LICENSE file #1626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1546717
to
8300762
Compare
@@ -42,6 +42,8 @@ | ||
s.move( | ||
templated_files, | ||
excludes=[ | ||
# Need a combined LICENSE for all vendored packages. | ||
"LICENSE", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a heads up: LICENSE
is no longer part of synthtool templates. We may need to update the post processor image if owlbot is reverting changes.
https://github.com/googleapis/synthtool/tree/master/synthtool/gcp/templates/python_library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Yeah, next image update we can remove this line.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕