docs: include all licenses for vendored packages in the root LICENSE file #1626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1546717 to
8300762
Compare
sycai
approved these changes
Apr 17, 2025
parthea
reviewed
Apr 17, 2025
| @@ -42,6 +42,8 @@ | ||
| s.move( | ||
| templated_files, | ||
| excludes=[ | ||
| # Need a combined LICENSE for all vendored packages. | ||
| "LICENSE", |
There was a problem hiding this comment.
Just a heads up: LICENSE is no longer part of synthtool templates. We may need to update the post processor image if owlbot is reverting changes.
https://github.com/googleapis/synthtool/tree/master/synthtool/gcp/templates/python_library
There was a problem hiding this comment.
Got it. Yeah, next image update we can remove this line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕