Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

docs: include all licenses for vendored packages in the root LICENSE file #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 17, 2025

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Apr 17, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@tswast tswast requested review from a team as code owners April 17, 2025 14:39
@tswast tswast requested a review from TrevorBergeron April 17, 2025 14:39
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Apr 17, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Apr 17, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. size: u Pull request is empty. and removed size: l Pull request size is large. size: m Pull request size is medium. labels Apr 17, 2025
@tswast tswast force-pushed the b319116851-AllLicensesRecorded branch from 1546717 to 8300762 Compare April 17, 2025 15:04
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: u Pull request is empty. labels Apr 17, 2025
@tswast tswast changed the title chore: combine all licenses into one file docs: combine all licenses into one file Apr 17, 2025
@tswast tswast changed the title docs: combine all licenses into one file docs: combine all licenses for vendored packages into one file Apr 17, 2025
@tswast tswast changed the title docs: combine all licenses for vendored packages into one file docs: include all licenses for vendored packages in the root LICENSE file Apr 17, 2025
@tswast tswast enabled auto-merge (squash) April 17, 2025 15:07
@@ -42,6 +42,8 @@
s.move(
templated_files,
excludes=[
# Need a combined LICENSE for all vendored packages.
"LICENSE",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up: LICENSE is no longer part of synthtool templates. We may need to update the post processor image if owlbot is reverting changes.

https://github.com/googleapis/synthtool/tree/master/synthtool/gcp/templates/python_library

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Yeah, next image update we can remove this line.

@tswast tswast disabled auto-merge April 17, 2025 15:28
@tswast tswast merged commit 8116ed0 into main Apr 17, 2025
16 of 24 checks passed
@tswast tswast deleted the b319116851-AllLicensesRecorded branch April 17, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.