Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

chore: define timedelta type and to_timedelta function #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 27, 2025
Merged

Conversation

sycai
Copy link
Contributor

@sycai sycai commented Jan 23, 2025

This change only introduces the timedelta type into the BigFrames system and makes sure the local representation looks correct.

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jan 23, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Jan 23, 2025
@sycai sycai marked this pull request as ready for review January 23, 2025 19:46
@sycai sycai requested review from a team as code owners January 23, 2025 19:46
@sycai sycai requested a review from chelsea-lin January 23, 2025 19:46
@sycai sycai added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 27, 2025
@bigframes-bot bigframes-bot removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 27, 2025
@sycai sycai enabled auto-merge (squash) January 27, 2025 21:48
@sycai sycai merged commit 3901951 into main Jan 27, 2025
22 checks passed
@sycai sycai deleted the sycai_timedelta branch January 27, 2025 21:48
shuoweil pushed a commit that referenced this pull request Jan 28, 2025
* define timedelta type and to_timedelta function

* remove unnecessary file

* remove TypeAlias type for 3.9 compatibility

* fix mypy

* fix lint

* move timedelta out of the simple dtype list

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix type casts in tests

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.