deps: Add support for Python 3.13 for everything but remote functions #1307

arwas11 · Jan 21, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #393138101 🦕

tswast · Jan 22, 2025

Re: unit-3.13 failures,

ERROR scripts/test_publish_api_coverage.py::test_api_coverage_produces_expected_schema - NameError: name 'sklearn' is not defined
ERROR scripts/test_publish_api_coverage.py::test_api_coverage_produces_missing_parameters - NameError: name 'sklearn' is not defined

Let's skip these tests if scikit-learn is not installed. You can use the pytest.importorskip("sklearn") function.

…te-to-python-3-13

tswast · Jan 24, 2025

Getting "400 Runtime 'python313' is not supported." on remote functions tests. Let's skip those tests on Python 3.13 for now.

Edit: See supported runtime: https://cloud.google.com/functions/docs/runtime-support#python

third_party/bigframes_vendored/pandas/core/series.py

tswast · Jan 28, 2025

e2e failures:

FAILED tests/system/small/test_series.py::test_series_bool_bool_operators_scalar[False-other_scalar2-and]
FAILED tests/system/small/test_series.py::test_series_bool_bool_operators_scalar[False-other_scalar2-or]
FAILED tests/system/small/test_series.py::test_series_bool_bool_operators_scalar[False-other_scalar2-xor]
FAILED tests/system/small/test_remote_function.py::test_remote_function_application_repr
FAILED tests/system/small/test_remote_function.py::test_remote_function_direct_no_session_param
FAILED tests/system/small/test_remote_function.py::test_df_apply_axis_1 - goo...
FAILED tests/system/small/test_remote_function.py::test_remote_function_direct_no_session_param_location_specified
FAILED tests/system/small/test_remote_function.py::test_remote_function_unary_applied_after_filter[apply]
FAILED tests/system/small/test_remote_function.py::test_df_apply_axis_1_ordering
FAILED tests/system/small/test_remote_function.py::test_remote_function_direct_no_session_param_location_project_specified
FAILED tests/system/small/test_remote_function.py::test_remote_function_unary_applied_after_filter[map]
FAILED tests/system/small/test_remote_function.py::test_df_apply_axis_1_multiindex
FAILED tests/system/small/test_remote_function.py::test_remote_function_direct_session_param
FAILED tests/system/small/test_remote_function.py::test_remote_function_unary_applied_after_filter[mask]
FAILED tests/system/small/test_remote_function.py::test_df_apply_axis_1_unsupported_dtype
FAILED tests/system/small/test_remote_function.py::test_remote_function_via_session_default
FAILED tests/system/small/test_remote_function.py::test_remote_function_binary_applied_after_filter
FAILED tests/system/small/test_remote_function.py::test_remote_function_via_session_with_overrides
FAILED tests/system/small/test_remote_function.py::test_remote_function_nary_applied_after_filter
FAILED tests/system/small/test_remote_function.py::test_remote_function_unary_partial_ordering_mode_assign[apply]
FAILED tests/system/small/test_remote_function.py::test_remote_function_unary_partial_ordering_mode_assign[map]
FAILED tests/system/small/test_remote_function.py::test_remote_function_unary_partial_ordering_mode_assign[mask]
FAILED tests/system/small/test_remote_function.py::test_dataframe_applymap - ...
FAILED tests/system/small/test_remote_function.py::test_remote_function_binary_partial_ordering_mode_assign
FAILED tests/system/small/test_remote_function.py::test_dataframe_applymap_explicit_filter
FAILED tests/system/small/test_remote_function.py::test_remote_function_nary_partial_ordering_mode_assign
FAILED tests/system/small/test_remote_function.py::test_dataframe_applymap_na_ignore
FAILED tests/system/small/test_remote_function.py::test_series_map_bytes - go...
FAILED tests/system/small/test_remote_function.py::test_skip_bq_connection_check
FAILED tests/system/small/test_remote_function.py::test_read_gbq_function_like_original
30 failed, 2484 passed, 8 skipped, 42 xfailed, 2 xpassed, 713 warnings, 23 retried in 2864.77s (0:47:44)
nox > Command py.test --quiet -n=20 --timeout=900 --durations=20 --junitxml=system_noextras_3.13_sponge_log.xml tests/system/small failed with exit code 1
nox > Session system_noextras failed.

Need to update system_noextras to use Python 3.12, too.

noxfile.py

tswast · Jan 28, 2025

doctest failed a package installation step. I'll retry the job.

tswast · Jan 28, 2025

notebook failure notebooks/remote_functions/remote_function_vertex_claude_model.ipynb not related.

…te-to-python-3-13

tswast · Jan 29, 2025

e2e tests are passing!

notebook failure actually does look related this time:

FAILED notebooks/remote_functions/remote_function_vertex_claude_model.ipynb::remote_function_vertex_claude_model.ipynb - InvalidArgument: 400 Runtime 'python313' is not supported. Supported runtimes

Some options:

It may be worth adding a check for Python 3.13 at the top of these notebooks:

Failed: getting_started/getting_started_bq_dataframes.ipynb
Failed: location/regionalized.ipynb_asia-southeast1
Failed: location/regionalized.ipynb_eu
Failed: location/regionalized.ipynb_europe-west4
Failed: location/regionalized.ipynb_southamerica-west1
Failed: location/regionalized.ipynb_us-central1
Failed: location/regionalized.ipynb_us
Failed: remote_functions/remote_function.ipynb
Failed: remote_functions/remote_function_usecases.ipynb
Failed: remote_functions/remote_function_vertex_claude_model.ipynb

If it is Python 3.13, then exit early with sys.exit(0). We can have a comment saying that Python 3.13 is not yet a supported runtime and to watch https://cloud.google.com/functions/docs/runtime-support#python for support for remote functions.

review-notebook-app · Jan 29, 2025

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

chore: Add support for Python 3.13

14cefcd

arwas11 requested a review from tswast January 21, 2025 21:50

product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 21, 2025

arwas11 and others added 3 commits January 21, 2025 15:54

Merge branch 'main' into update-to-python-3-13

e8e4811

Merge remote-tracking branch 'origin/main' into update-to-python-3-13

9f65105

update contibuting.rst with the the new version

c998c11

arwas11 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 22, 2025

bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 22, 2025

arwas11 and others added 6 commits January 22, 2025 15:04

skip sklearn import

0a46d4a

Merge branch 'main' into update-to-python-3-13

8414fad

Merge remote-tracking branch 'origin/main' into update-to-python-3-13

d75a1b3

Merge remote-tracking branch 'origin/update-to-python-3-13' into upda…

db78d65

…te-to-python-3-13

skip api coverage tests because of sklearn NameError

4c9e4a6

Merge remote-tracking branch 'origin/main' into update-to-python-3-13

1bd284d

skip remote function tests

678b676

product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jan 24, 2025

skip all remote function tests and doctests

25bc738

product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Jan 24, 2025

tswast reviewed Jan 27, 2025

View reviewed changes

third_party/bigframes_vendored/pandas/core/series.py Outdated Show resolved Hide resolved

update doctest python version to 3.12 in noxfile

106af9a

product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jan 28, 2025

Merge branch 'main' into update-to-python-3-13

cf91455

tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 28, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 28, 2025

tswast marked this pull request as ready for review January 28, 2025 17:08

tswast requested review from a team as code owners January 28, 2025 17:08

tswast requested a review from GarrettWu January 28, 2025 17:08

blunderbuss-gcf bot assigned TrevorBergeron Jan 28, 2025

tswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 28, 2025

Update noxfile.py

57f7227

tswast reviewed Jan 28, 2025

View reviewed changes

noxfile.py Show resolved Hide resolved

Merge branch 'main' into update-to-python-3-13

213eaeb

tswast changed the title ~~chore: Add support for Python 3.13~~ deps: Add support for Python 3.13 Jan 28, 2025

arwas11 and others added 6 commits January 28, 2025 13:13

Merge branch 'main' into update-to-python-3-13

875f59a

Merge branch 'main' into update-to-python-3-13

3fca9ab

fix the system_pre-release error

366e4f8

Merge remote-tracking branch 'origin/update-to-python-3-13' into upda…

a389687

…te-to-python-3-13

Merge branch 'main' into update-to-python-3-13

102f2cb

Merge branch 'main' into update-to-python-3-13

ad9110b

tswast added 2 commits January 29, 2025 09:11

Merge remote-tracking branch 'origin/main' into update-to-python-3-13

d3279d6

skip remote functions notebooks on 3.13 tests

66f584d

🦉 Updates from OwlBot post-processor

770fef2

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

tswast changed the title ~~deps: Add support for Python 3.13~~ deps: Add support for Python 3.13 for everything but remote functions Jan 29, 2025

tswast enabled auto-merge (squash) January 29, 2025 17:59

tswast removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 29, 2025

tswast merged commit 533db96 into main Jan 29, 2025
24 checks passed

tswast deleted the update-to-python-3-13 branch January 29, 2025 18:04

release-please bot mentioned this pull request Jan 29, 2025

chore(main): release 1.35.0 #1331

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

deps: Add support for Python 3.13 for everything but remote functions #1307

deps: Add support for Python 3.13 for everything but remote functions #1307

Uh oh!

arwas11 commented Jan 21, 2025 •

edited

Loading

Uh oh!

tswast commented Jan 22, 2025

Uh oh!

tswast commented Jan 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

tswast commented Jan 28, 2025

Uh oh!

Uh oh!

tswast commented Jan 28, 2025

Uh oh!

tswast commented Jan 28, 2025

Uh oh!

tswast commented Jan 29, 2025

Uh oh!

review-notebook-app bot commented Jan 29, 2025

Uh oh!

Uh oh!

Uh oh!

Search code, repositories, users, issues, pull requests...

deps: Add support for Python 3.13 for everything but remote functions #1307

deps: Add support for Python 3.13 for everything but remote functions #1307

Uh oh!

Conversation

arwas11 commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tswast commented Jan 22, 2025

Uh oh!

tswast commented Jan 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

tswast commented Jan 28, 2025

Uh oh!

Uh oh!

tswast commented Jan 28, 2025

Uh oh!

tswast commented Jan 28, 2025

Uh oh!

tswast commented Jan 29, 2025

Uh oh!

review-notebook-app bot commented Jan 29, 2025

Uh oh!

Uh oh!

Uh oh!

arwas11 commented Jan 21, 2025 •

edited

Loading

tswast commented Jan 24, 2025 •

edited

Loading