fix: series sort_index and sort_values now raises when axis!=0 #1294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarrettWu
reviewed
Jan 16, 2025
bigframes/series.py
Outdated
| @@ -1347,6 +1347,8 @@ def value_counts( | ||
| def sort_values( | ||
| self, *, axis=0, ascending=True, kind: str = "quicksort", na_position="last" | ||
| ) -> Series: | ||
| if axis != 0: |
There was a problem hiding this comment.
Is the behavior the same as pandas? Looks like pandas just ignores the param. https://pandas.pydata.org/docs/reference/api/pandas.Series.sort_index.html
Also it can take "index".
GarrettWu
approved these changes
Jan 16, 2025
shuoweil
pushed a commit
that referenced
this pull request
Jan 20, 2025
* fix: series sort_index and sort_values now raises when axis!=0 * update keyword index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕