Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: series sort_index and sort_values now raises when axis!=0 #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

Genesis929
Copy link
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 16, 2025
@Genesis929 Genesis929 marked this pull request as ready for review January 16, 2025 20:15
@Genesis929 Genesis929 requested review from a team as code owners January 16, 2025 20:15
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Jan 16, 2025
@Genesis929 Genesis929 requested a review from GarrettWu January 16, 2025 20:16
@@ -1347,6 +1347,8 @@ def value_counts(
def sort_values(
self, *, axis=0, ascending=True, kind: str = "quicksort", na_position="last"
) -> Series:
if axis != 0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the behavior the same as pandas? Looks like pandas just ignores the param. https://pandas.pydata.org/docs/reference/api/pandas.Series.sort_index.html

Also it can take "index".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@Genesis929 Genesis929 requested a review from GarrettWu January 16, 2025 21:21
@Genesis929 Genesis929 enabled auto-merge (squash) January 16, 2025 21:21
@Genesis929 Genesis929 disabled auto-merge January 16, 2025 22:02
@Genesis929 Genesis929 merged commit 94bc2f2 into main Jan 16, 2025
22 checks passed
@Genesis929 Genesis929 deleted the axis_usage_fix_huanc branch January 16, 2025 23:19
shuoweil pushed a commit that referenced this pull request Jan 20, 2025
* fix: series sort_index and sort_values now raises when axis!=0

* update keyword index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.