Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: support time_series_id_col in ARIMAPlus #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 28, 2025
Merged

feat: support time_series_id_col in ARIMAPlus #1282

merged 10 commits into from
Jan 28, 2025

Conversation

shuoweil
Copy link
Contributor

@shuoweil shuoweil commented Jan 11, 2025 •
edited
Loading

feat: support time_series_id_col in ARIMAPlus,
(1) introduce time_series_id_col as an optional input feature, user needs to specific which column is used as time_series_id_col.
(2) update all testcases to test the original ARIMA plus model (without id_col) and new ARIMA plus model (with id_col).
(3) for generality test, expand the input dataset to include multiple ids for the same date

@shuoweil shuoweil requested a review from GarrettWu January 11, 2025 02:52
@shuoweil shuoweil self-assigned this Jan 11, 2025
@shuoweil shuoweil requested review from a team as code owners January 11, 2025 02:52
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 11, 2025
@shuoweil shuoweil enabled auto-merge (squash) January 11, 2025 02:52
@shuoweil shuoweil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 11, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 11, 2025
@shuoweil shuoweil requested a review from tswast January 13, 2025 18:55
GarrettWu
GarrettWu reviewed Jan 13, 2025
View reviewed changes
tests/system/conftest.py Outdated Show resolved Hide resolved
bigframes/ml/core.py Outdated Show resolved Hide resolved
bigframes/ml/core.py Outdated Show resolved Hide resolved
bigframes/ml/forecasting.py Outdated Show resolved Hide resolved
@shuoweil shuoweil requested a review from a team as a code owner January 20, 2025 01:26
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Jan 20, 2025 •
edited
Loading

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@shuoweil shuoweil closed this Jan 20, 2025
auto-merge was automatically disabled January 20, 2025 01:34

Pull request was closed

@shuoweil shuoweil reopened this Jan 20, 2025
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jan 20, 2025
@shuoweil shuoweil requested review from GarrettWu and removed request for msampathkumar and a team January 20, 2025 01:52
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Jan 20, 2025
@shuoweil shuoweil closed this Jan 20, 2025
@shuoweil shuoweil reopened this Jan 20, 2025
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Jan 20, 2025
@shuoweil shuoweil enabled auto-merge (squash) January 20, 2025 04:33
@product-auto-label product-auto-label bot added size: m Pull request size is medium. size: l Pull request size is large. and removed size: xl Pull request size is extra large. size: m Pull request size is medium. labels Jan 24, 2025
@shuoweil shuoweil disabled auto-merge January 24, 2025 20:53
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jan 24, 2025
@shuoweil shuoweil requested a review from GarrettWu January 24, 2025 23:15
@shuoweil shuoweil enabled auto-merge (squash) January 24, 2025 23:15
GarrettWu
GarrettWu reviewed Jan 27, 2025
View reviewed changes
bigframes/ml/forecasting.py Outdated Show resolved Hide resolved
bigframes/ml/forecasting.py Show resolved Hide resolved
bigframes/ml/forecasting.py Show resolved Hide resolved
tests/system/small/ml/test_core.py Outdated Show resolved Hide resolved
@shuoweil shuoweil requested a review from GarrettWu January 28, 2025 20:23
@shuoweil shuoweil merged commit 97532c9 into main Jan 28, 2025
22 checks passed
@shuoweil shuoweil deleted the shuowei-arima-plus branch January 28, 2025 22:24
@release-please release-please bot mentioned this pull request Jan 28, 2025
Merged
@tswast tswast mentioned this pull request Jan 30, 2025
Merged
4 tasks
@tswast tswast mentioned this pull request Feb 6, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

@tswast tswast Awaiting requested review from tswast

Assignees

@shuoweil shuoweil

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shuoweil @GarrettWu @bigframes-bot @shobsi
Morty Proxy This is a proxified and sanitized view of the page, visit original site.