deps: remove sqlglot upper bound #1278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
tswast
reviewed
Jan 9, 2025
|
Test failure is |
e1ca380 to
43f4c1f
Compare
tswast
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #942 🦕
Additionally this allows use of bigframes with SQLMesh. If this is merged, I will build first class support into SQLMesh which opens up BigFrames usage to the audience of folks building transformations for their org with that tool.
The upper bound is removed in this PR. This helps libraries include bigframes as a package. SQLMesh team are also the stewards of SQLGlot and hence they ride the bleeding edge. An upper bound would eventually introduce dependency hell (unresolvable). I checked the API surface area of what is being used in sqlglot. It seems quite minor outside what
ibis/expr/sql.pytouches.