-
Notifications
You must be signed in to change notification settings - Fork 50
deps: remove sqlglot upper bound #1278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: remove sqlglot upper bound #1278
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
I'm curious to see the results of our test suite with this change.
Test failure is |
e1ca380
to
43f4c1f
Compare
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #942 🦕
Additionally this allows use of bigframes with SQLMesh. If this is merged, I will build first class support into SQLMesh which opens up BigFrames usage to the audience of folks building transformations for their org with that tool.
The upper bound is removed in this PR. This helps libraries include bigframes as a package. SQLMesh team are also the stewards of SQLGlot and hence they ride the bleeding edge. An upper bound would eventually introduce dependency hell (unresolvable). I checked the API surface area of what is being used in sqlglot. It seems quite minor outside what
ibis/expr/sql.py
touches.