Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

deps: remove sqlglot upper bound #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

z3z1ma
Copy link
Contributor

@z3z1ma z3z1ma commented Jan 9, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #942 🦕

Additionally this allows use of bigframes with SQLMesh. If this is merged, I will build first class support into SQLMesh which opens up BigFrames usage to the audience of folks building transformations for their org with that tool.

The upper bound is removed in this PR. This helps libraries include bigframes as a package. SQLMesh team are also the stewards of SQLGlot and hence they ride the bleeding edge. An upper bound would eventually introduce dependency hell (unresolvable). I checked the API surface area of what is being used in sqlglot. It seems quite minor outside what ibis/expr/sql.py touches.

@z3z1ma z3z1ma requested review from a team as code owners January 9, 2025 17:36
@z3z1ma z3z1ma requested a review from shobsi January 9, 2025 17:36
Copy link

google-cla bot commented Jan 9, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 9, 2025
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I'm curious to see the results of our test suite with this change.

testing/constraints-3.9.txt Outdated Show resolved Hide resolved
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 9, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 9, 2025
@tswast tswast changed the title Chore: remove sqlglot upper bound deps: remove sqlglot upper bound Jan 9, 2025
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 9, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 9, 2025
@tswast
Copy link
Collaborator

tswast commented Jan 9, 2025

Test failure is FAILED tests/system/small/ml/test_llm.py::test_create_load_gemini_text_generator_model[gemini-1.5-pro-0 which appears to be a quota-related flake. I can retry in the morning.

@z3z1ma z3z1ma force-pushed the chore/relax-sqlglot-upper-bound branch from e1ca380 to 43f4c1f Compare January 10, 2025 16:05
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 10, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 10, 2025
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 10, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 10, 2025
@tswast tswast added owlbot:ignore instruct owl-bot to ignore a PR owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:ignore instruct owl-bot to ignore a PR labels Jan 10, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2025
@tswast tswast merged commit c71ec09 into googleapis:main Jan 10, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally relax sqlglot / ibis pin via env var for use in SQLMesh
5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.