Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: implement confirmation threshold for semantic operators #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jan 3, 2025
Merged

feat: implement confirmation threshold for semantic operators #1251

merged 16 commits into from
Jan 3, 2025

Conversation

sycai
Copy link
Contributor

@sycai sycai commented Jan 3, 2025 •
edited
Loading

If the amount of row to be processed exceeds this threshold, we will ask for keyboard input from user to confirm.

@sycai sycai requested review from a team as code owners January 3, 2025 01:33
@sycai sycai requested a review from jialuoo January 3, 2025 01:34
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jan 3, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Jan 3, 2025
@sycai sycai requested a review from tswast January 3, 2025 01:36
tswast
tswast requested changes Jan 3, 2025
View reviewed changes
bigframes/_config/compute_options.py Outdated Show resolved Hide resolved
bigframes/operations/semantics.py Outdated Show resolved Hide resolved
bigframes/operations/semantics.py Outdated Show resolved Hide resolved
bigframes/operations/semantics.py Outdated Show resolved Hide resolved
bigframes/operations/semantics.py Outdated Show resolved Hide resolved
bigframes/_config/compute_options.py Outdated Show resolved Hide resolved
@sycai sycai requested a review from tswast January 3, 2025 19:04
tswast
tswast reviewed Jan 3, 2025
View reviewed changes
tests/system/large/operations/test_semantics.py Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jan 3, 2025
@sycai sycai requested a review from tswast January 3, 2025 21:50
@sycai sycai enabled auto-merge (squash) January 3, 2025 23:17
@sycai sycai merged commit 5ba4511 into main Jan 3, 2025
21 of 22 checks passed
@sycai sycai deleted the b386261373 branch January 3, 2025 23:43
@release-please release-please bot mentioned this pull request Jan 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@jialuoo jialuoo Awaiting requested review from jialuoo jialuoo is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

@junyazhang junyazhang

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sycai @tswast @junyazhang
Morty Proxy This is a proxified and sanitized view of the page, visit original site.