Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

chore: Remove six dependency #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 8, 2021
Merged

chore: Remove six dependency #461

merged 2 commits into from
Jan 8, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Jan 7, 2021

Closes #460.

This PR gets rid of six that we don't need anymore after dropping Python 2 support.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added the type: cleanup An internal cleanup or hygiene concern. label Jan 7, 2021
@plamut plamut requested a review from a team January 7, 2021 12:21
@plamut plamut requested a review from a team as a code owner January 7, 2021 12:21
@plamut plamut requested review from pmakani and dinagraves and removed request for a team January 7, 2021 12:21
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jan 7, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 7, 2021
@tswast tswast requested review from tswast and removed request for pmakani January 7, 2021 15:30
tswast
tswast approved these changes Jan 8, 2021
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast tswast merged commit 0023d19 into googleapis:master Jan 8, 2021
@plamut plamut deleted the iss-460 branch January 8, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@dinagraves dinagraves Awaiting requested review from dinagraves

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove six dependency
2 participants
@plamut @tswast
Morty Proxy This is a proxified and sanitized view of the page, visit original site.