Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

refactor: simplify AutoStrEnum definition #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2021
Merged

refactor: simplify AutoStrEnum definition #458

merged 1 commit into from
Jan 11, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Jan 7, 2021

Closes #457.

With now only Python 3.6 supported, we can use the _generate_next_value() hook instead of metaclass magic. No new tests, as the existing tests already cover this code.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut
refactor: simplify AutoStrEnum definition
ce0d0ed 
With now only Python 3.6 supported, we can use the
_generate_next_value() hook instead of metaclass magic.
@plamut plamut added the type: cleanup An internal cleanup or hygiene concern. label Jan 7, 2021
@plamut plamut requested review from a team and steffnay and removed request for a team January 7, 2021 09:05
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 7, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jan 7, 2021
@plamut
Copy link
Contributor Author

plamut commented Jan 7, 2021

I'm not entirely sure that the docs-presubmit failure is about, something about the missing python3.6 command when setting up the tests.

I see the same error on other PRs, thus it doesn't seem to be caused by the changes here.

tswast
tswast approved these changes Jan 8, 2021
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@plamut plamut merged commit fb3ad76 into googleapis:master Jan 11, 2021
@plamut plamut deleted the iss-457 branch January 11, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@steffnay steffnay Awaiting requested review from steffnay

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify AutoStrEnum definition in Jupyter magic's argument parser
2 participants
@plamut @tswast
Morty Proxy This is a proxified and sanitized view of the page, visit original site.