Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

test: add session to test with nightly dependencies #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2020
Merged

test: add session to test with nightly dependencies #449

merged 1 commit into from
Dec 22, 2020

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Dec 22, 2020

This should catch errors introduced in the next versions of dependency
packages.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #95 🦕

@tswast
test: add session to test with nightly dependencies
840f55e 
This should catch errors introduced in the next versions of dependency
packages.
@tswast tswast requested review from a team and steffnay and removed request for a team December 22, 2020 20:40
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Dec 22, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 22, 2020
@tswast
Copy link
Contributor Author

tswast commented Dec 22, 2020

Sent internal CL 348679818 to get Kokoro running.

The nox session does pass locally on my mac.

$ nox -s prerelease_deps
nox > Running session prerelease_deps
nox > Creating virtual environment (virtualenv) using python3.8 in .nox/prerelease_deps
nox > pip install --extra-index-url https://pypi.fury.io/arrow-nightlies/ --pre pyarrow
nox > pip install --pre grpcio pandas
nox > pip install mock pytest google-cloud-testutils pytest-cov freezegun IPython
nox > pip install -e .[all]
nox > python -c import grpc; print(grpc.__version__)
1.34.0
nox > python -c import pandas; print(pandas.__version__)
1.2.0rc0
nox > python -c import pyarrow; print(pyarrow.__version__)
2.1.0.dev213
nox > py.test tests
=========================================================== test session starts ===========================================================
platform darwin -- Python 3.8.6, pytest-6.2.1, py-1.10.0, pluggy-0.13.1
rootdir: /Users/swast/src/python-bigquery
plugins: cov-2.10.1
collected 1509 items                                                                                                                      
.
.
.
nox > Session prerelease_deps was successful.

@tswast
Copy link
Contributor Author

tswast commented Dec 22, 2020

Build successful 🎉
https://source.cloud.google.com/results/invocations/4354074d-63c2-48d2-8dca-8c3495b2e430/targets

@tswast tswast merged commit aac33df into googleapis:master Dec 22, 2020
@tswast tswast deleted the issue95-pyarrow-nightly branch December 22, 2020 22:20
@tseaver tseaver mentioned this pull request Aug 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@steffnay steffnay Awaiting requested review from steffnay

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration test with pyarrow nightly builds?
2 participants
@tswast @busunkim96
Morty Proxy This is a proxified and sanitized view of the page, visit original site.